feat(Stack): default direction to vertical - #1945
Merged
Merged
Conversation
XDSStack now defaults to direction='vertical' when omitted. Vertical is the most common layout direction (482 vs 126 usages in the codebase), and LLMs frequently hallucinate bare <XDSStack> without any direction prop — which previously was a type error. Defaulting to vertical makes the zero-prop case work correctly.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
meta-cla
Bot
added
the
CLA Signed
cixzhang
enabled auto-merge (squash)
May 2, 2026 00:46
Contributor
PR Analysis Report📚 Storybook PreviewView Storybook for this PR 🧪 Sandbox PreviewView Sandbox for this PR No new or modified components detected. Bundle Size Summary
Accessibility AuditStatus: No accessibility violations detected. Generated by PR Enrichment workflow | Storybook | Sandbox | View full report |
cixzhang
added a commit
that referenced
this pull request
Jun 21, 2026
XDSStack now defaults to direction='vertical' when omitted. Vertical is the most common layout direction (482 vs 126 usages in the codebase), and LLMs frequently hallucinate bare <XDSStack> without any direction prop — which previously was a type error. Defaulting to vertical makes the zero-prop case work correctly.
cixzhang
added a commit
that referenced
this pull request
Jun 21, 2026
XDSStack now defaults to direction='vertical' when omitted. Vertical is the most common layout direction (482 vs 126 usages in the codebase), and LLMs frequently hallucinate bare <XDSStack> without any direction prop — which previously was a type error. Defaulting to vertical makes the zero-prop case work correctly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Makes
direction="vertical"the default forXDSStack, so<XDSStack>without a direction prop renders a vertical stack.Why
Vertical is the overwhelmingly common case — 482 vertical vs 126 horizontal usages in the codebase. More importantly, LLMs frequently hallucinate bare
<XDSStack>without specifying direction, which was previously a type error. Defaulting to vertical makes the zero-prop case just work.Changes
XDSStack.tsx:directionprop is now optional, defaults to'vertical'XDSStack.test.tsx: Added test for default direction behaviorStack.stories.tsx: Default story no longer passes explicit directionNon-breaking
Existing code that passes
direction="vertical"ordirection="horizontal"is unaffected. Only the previously-invalid case of omitting direction is now valid.