fix(Tokenizer): add status to xdsClassName for theme targeting - #1995
Merged
Conversation
Tokenizer's xdsClassName call only included size, missing the status prop that drives visual border/shadow styles. This meant themes couldn't distinguish tokenizer status states (error, warning, etc.) via the xds-tokenizer-[status] class. Add status?.type to both xdsClassName calls (main wrapper and layer placeholder) to match the pattern already used by XDSTypeahead.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
meta-cla
Bot
added
the
CLA Signed
cixzhang
enabled auto-merge (squash)
May 3, 2026 10:48
Contributor
PR Analysis Report📚 Storybook PreviewView Storybook for this PR 🧪 Sandbox PreviewView Sandbox for this PR No new or modified components detected. Bundle Size Summary
Accessibility AuditStatus: No accessibility violations detected. Generated by PR Enrichment workflow | Storybook | Sandbox | View full report |
cixzhang
added a commit
that referenced
this pull request
Jun 21, 2026
cixzhang
added a commit
that referenced
this pull request
Jun 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tokenizer's
xdsClassNamecall only includedsize, missing thestatusprop that drives visual border/shadow styles viainputStatusBorderStyles[status.type]. Themes couldn't distinguish tokenizer status states (error, warning, etc.) via thexds-tokenizer-[status]class.Changes
Add
status?.typeto bothxdsClassNamecalls (main wrapper and layer placeholder) to match the pattern already used by XDSTypeahead.Audit Notes
Found during Night Watch Component Auditor pass over hardening queue components (Token, Tokenizer, Tooltip, TreeList, Typeahead).
Other components audited — no issues found:
color+size, all visual props covered. Uses proper tokens throughout.density,selected,disabled— all visual props covered.statusin xdsClassName — no fix needed.Noted for human review (not fixed here):
XDSBaseProps— they manually definexstyle/className/style. This means they missdata-*support from XDSBaseProps. Broader API pattern decision needed.refprop — may need imperative handle similar to XDSTokenizer'sXDSTokenizerHandle.Night Watch — Component Auditor