fix(TopNav): add selected state to TopNavItem xdsClassName - #1997
Merged
Conversation
TopNavItem's xdsClassName call didn't include the isSelected state, even though it drives visual styles (background color, font weight). This meant themes couldn't distinguish selected vs unselected nav items via the xds-top-nav-item-selected class. Add selected state to both xdsClassName calls (drawer mode and default mode), following the same pattern used by TreeListItem.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
meta-cla
Bot
added
the
CLA Signed
Contributor
PR Analysis Report📚 Storybook PreviewView Storybook for this PR 🧪 Sandbox PreviewView Sandbox for this PR No new or modified components detected. Bundle Size Summary
Accessibility AuditStatus: No accessibility violations detected. Generated by PR Enrichment workflow | Storybook | Sandbox | View full report |
cixzhang
added a commit
that referenced
this pull request
Jun 21, 2026
cixzhang
added a commit
that referenced
this pull request
Jun 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TopNavItem's
xdsClassNamecall didn't include theisSelectedstate, even though it drives visual styles (background color, font weight). Themes couldn't distinguish selected vs unselected nav items via thexds-top-nav-item-selectedclass.Changes
Add
selectedstate to bothxdsClassNamecalls (drawer mode and default mode), following the same pattern used by TreeListItem.Audit Notes
Found during Night Watch Component Auditor pass over queue components (Timestamp, TopNav).
Timestamp — audited, no issues found. Uses xdsClassName with format variant, proper token usage, extends XDSBaseProps.
TopNav — this fix. All sub-components checked:
Queue status: All 63 core components have now been audited. Queue will rebuild on next run.
Night Watch — Component Auditor