fix(nav): remove hover popover open delay to prevent flickering - #2133
Merged
Conversation
|
@ernestt must be a member of the Meta Open Source team on Vercel to deploy. Learn more about collaboration on Vercel and other options here. |
meta-cla
Bot
added
the
CLA Signed
cixzhang
approved these changes
May 11, 2026
cixzhang
left a comment
cixzhang
left a comment
Contributor
There was a problem hiding this comment.
Seems okay. It should only affects the hover open pathway but might be annoying if the user is scanning. I guess we can try it and see.
XDSSideNavHeading and XDSTopNavHeading are single-item triggers where the 150ms show delay was causing visible flickering without serving its debounce purpose (there's only one heading, not a row of items). Pass showDelay: 0 to useXDSMenuHover in both heading components so the popover opens immediately on hover. The hook is also updated to skip the unnecessary setTimeout when showDelay is 0. Other nav items (XDSTopNavMenu, XDSTopNavMegaMenu, XDSSideNavItem) keep their 150ms delay since they appear in groups where debouncing is useful.
ernestt
force-pushed
the
navi/fix/remove-popover-open-delay
branch
from
May 11, 2026 21:59
9981696 to
bcc78a2
Compare
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
PR Analysis Report📚 Storybook PreviewView Storybook for this PR 🧪 Sandbox PreviewView Sandbox for this PR No new or modified components detected. Bundle Size Summary
Accessibility AuditStatus: No accessibility violations detected. Generated by PR Enrichment workflow | Storybook | Sandbox | View full report |
cixzhang
pushed a commit
that referenced
this pull request
Jun 21, 2026
XDSSideNavHeading and XDSTopNavHeading are single-item triggers where the 150ms show delay was causing visible flickering without serving its debounce purpose (there's only one heading, not a row of items). Pass showDelay: 0 to useXDSMenuHover in both heading components so the popover opens immediately on hover. The hook is also updated to skip the unnecessary setTimeout when showDelay is 0. Other nav items (XDSTopNavMenu, XDSTopNavMegaMenu, XDSSideNavItem) keep their 150ms delay since they appear in groups where debouncing is useful.
cixzhang
pushed a commit
that referenced
this pull request
Jun 21, 2026
XDSSideNavHeading and XDSTopNavHeading are single-item triggers where the 150ms show delay was causing visible flickering without serving its debounce purpose (there's only one heading, not a row of items). Pass showDelay: 0 to useXDSMenuHover in both heading components so the popover opens immediately on hover. The hook is also updated to skip the unnecessary setTimeout when showDelay is 0. Other nav items (XDSTopNavMenu, XDSTopNavMegaMenu, XDSSideNavItem) keep their 150ms delay since they appear in groups where debouncing is useful.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the 150ms show delay on nav heading hover menus (
XDSSideNavHeadingandXDSTopNavHeading) to prevent flickering.Problem
The heading popover menus had a 150ms delay before opening on hover (inherited from the shared
useXDSMenuHoverhook default). Unlike nav items/menus which appear in groups where debouncing prevents accidental triggers, the heading is always a single target — the delay just caused visible flicker with no upside.Changes
XDSSideNavHeading— passesshowDelay: 0touseXDSMenuHoverXDSTopNavHeading— passesshowDelay: 0touseXDSMenuHoveruseXDSMenuHover— whenshowDelayis 0, callsshow()synchronously instead of wrapping in an unnecessarysetTimeout(..., 0)Not changed
XDSTopNavMenu,XDSTopNavMegaMenu, andXDSSideNavItemkeep their 150ms delay since they appear in groups where debouncing across multiple targets is useful.