fix(TopNav): stop click propagation on heading links in mixed mode - #2135
Merged
Conversation
When XDSTopNavHeading has both headingHref and menu (mixed mode), the root div receives triggerProps.onClick which toggles the menu popover. Clicks on the logo link and heading text link bubble up to this handler, causing the menu to toggle instead of (or in addition to) navigating. This makes the link click work inconsistently. Fix: add onClick stopPropagation to all link elements rendered inside the mixed-mode trigger div (logo LinkComponent, heading LinkComponent, superheading XDSLink, subheading XDSLink). The chevron button already had this — the links were just missing it.
|
@josephfarina must be a member of the Meta Open Source team on Vercel to deploy. Learn more about collaboration on Vercel and other options here. |
meta-cla
Bot
added
the
CLA Signed
Contributor
PR Analysis Report📚 Storybook PreviewView Storybook for this PR 🧪 Sandbox PreviewView Sandbox for this PR No new or modified components detected. Bundle Size Summary
Accessibility AuditStatus: No accessibility violations detected. Generated by PR Enrichment workflow | Storybook | Sandbox | View full report |
cixzhang
pushed a commit
that referenced
this pull request
Jun 21, 2026
…2135) When XDSTopNavHeading has both headingHref and menu (mixed mode), the root div receives triggerProps.onClick which toggles the menu popover. Clicks on the logo link and heading text link bubble up to this handler, causing the menu to toggle instead of (or in addition to) navigating. This makes the link click work inconsistently. Fix: add onClick stopPropagation to all link elements rendered inside the mixed-mode trigger div (logo LinkComponent, heading LinkComponent, superheading XDSLink, subheading XDSLink). The chevron button already had this — the links were just missing it.
cixzhang
pushed a commit
that referenced
this pull request
Jun 21, 2026
…2135) When XDSTopNavHeading has both headingHref and menu (mixed mode), the root div receives triggerProps.onClick which toggles the menu popover. Clicks on the logo link and heading text link bubble up to this handler, causing the menu to toggle instead of (or in addition to) navigating. This makes the link click work inconsistently. Fix: add onClick stopPropagation to all link elements rendered inside the mixed-mode trigger div (logo LinkComponent, heading LinkComponent, superheading XDSLink, subheading XDSLink). The chevron button already had this — the links were just missing it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When
XDSTopNavHeadinghas bothheadingHrefandmenuprops (mixed mode), clicking the logo or heading text inconsistently triggers navigation. Sometimes it opens the menu instead.Root Cause
In mixed mode, the root
<div>receivestriggerProps.onClickfromuseXDSMenuHoverwhich toggles the popover. Clicks on the logoLinkComponentand heading textLinkComponentbubble up to this handler, causing the menu to toggle instead of (or alongside) navigating.The chevron button already had
e.stopPropagation()— the link elements were just missing it.Fix
Add
onClick={e => e.stopPropagation()}to all link elements rendered inside the mixed-mode trigger div:LinkComponentLinkComponentXDSLinkXDSLinkThis ensures link clicks navigate cleanly without triggering the menu popover.
Repro
Click the logo rapidly — sometimes it navigates, sometimes the menu opens instead.