feat(core): add item endContent slots - #2802
Merged
Merged
Conversation
cixzhang
requested review from
ejhammond,
imdreamrunner,
josephfarina,
marie-lucas,
nynexman4464 and
thedjpetersen
as code owners
June 12, 2026 23:04
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
meta-cla
Bot
added
the
CLA Signed
Contributor
🚀 Vercel Preview Deployment
|
Contributor
PR Analysis Report📚 Storybook PreviewView Storybook for this PR 🧪 Sandbox PreviewView Sandbox for this PR No new or modified components detected. Bundle Size Summary
Accessibility AuditStatus: No accessibility violations detected. Generated by PR Enrichment workflow | Storybook | Sandbox | View full report |
cixzhang
force-pushed
the
navi/feat/dropdown-item-end-content
branch
from
June 12, 2026 23:36
4a1fb6d to
38f69db
Compare
cixzhang
force-pushed
the
navi/feat/dropdown-item-end-content
branch
from
June 13, 2026 03:55
38f69db to
1d1beec
Compare
cixzhang
added a commit
that referenced
this pull request
Jun 21, 2026
cixzhang
added a commit
that referenced
this pull request
Jun 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
endContenttoXDSDropdownMenuItemandXDSSelectorOptionchildrenprop while XDS is still prereleaseXDSContextMenuItemdocs to reflect the inheritedendContentslotmigrate-item-children-to-endcontentcodemod forXDSDropdownMenuItem,XDSContextMenuItem, andXDSSelectorOptionValidation
pnpm test packages/cli/src/codemods/transforms/v0.0.15/__tests__/migrate-item-children-to-endcontent.test.mjs packages/core/src/DropdownMenu/XDSDropdownMenu.test.tsx packages/core/src/ContextMenu/XDSContextMenu.test.tsx packages/core/src/Selector/XDSSelector.test.tsx packages/cli/src/codemods/__tests__/registry.test.mjs packages/cli/src/commands/upgrade.test.mjspnpm -F @xds/core typecheckpnpm -F @xds/core typecheck:docspnpm -F @xds/docsite generatepnpm check:syncpnpm check:package-boundariespnpm -F @xds/core buildnode packages/cli/bin/xds.mjs upgrade --codemod migrate-item-children-to-endcontent --path packages/lab/src/Schedule/plugins --applymigrated the local usage