fix(table): localize tree expander aria-label to unbreak lint on main#4149
Merged
Conversation
The tree data plugin (#3789) shipped hardcoded "Expand row" / "Collapse row" aria-labels on the expander button. The @astryx/no-hardcoded-i18n-string rule (added in #4010) flags these as errors, so `pnpm lint` fails repo-wide — main is red and every open PR inherits the failure. Route both strings through useTranslator() with new catalog keys @astryx.tableTree.expandRow / .collapseRow (mirroring the sibling selection and rowExpansion plugins) and add matching entries to packages/core/locales/en.json.
nynexman4464
requested review from
cixzhang,
ejhammond and
imdreamrunner
as code owners
July 21, 2026 23:19
meta-cla
Bot
added
the
CLA Signed
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
PR Analysis Report📚 Storybook PreviewView Storybook for this PR 🧪 Sandbox PreviewView Sandbox for this PR Modified ComponentsTable · View in Storybook
Bundle Size Summary
Accessibility AuditStatus: 1 accessibility violation(s) found — 1 serious. Table - 1 issue(s)
Generated by PR Enrichment workflow | Storybook | Sandbox | View full report |
josephfarina
approved these changes
Jul 22, 2026
Contributor
|
lg merging to unblock a pr i have! |
josephfarina
added a commit
that referenced
this pull request
Jul 22, 2026
Pull in #4149 (localize tree expander aria-label) which fixes the @astryx/no-hardcoded-i18n-string lint errors in useTableTreeData.tsx that were failing CI on the stale merge ref. Branch does not touch that file; merge is clean.
cixzhang
added a commit
that referenced
this pull request
Jul 22, 2026
Seven published-behavior PRs merged since v0.1.7 without a changeset, which would leave their contributors uncredited in the CHANGELOG. Add changesets so the v0.1.8 bump credits them: - core docs.mjs redirect to the CLI (#4207) - Table tree-data plugin: useTableTreeState / useTableTreeData (#3789) - Table tree expander aria-label localization (#4149) - foolproof init: postinstall nudges + non-interactive init (#4147, #4153, #4154, #4155)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Unbreaks
lintonmain. The tree data plugin (#3789, merged today) shipped hardcoded"Expand row"/"Collapse row"aria-labelstrings on the expander button. The@astryx/no-hardcoded-i18n-stringrule (added in #4010) flags these as errors, and thelintjob runspnpm lintrepo-wide — somainis currently red and every open PR inherits the failure (that's how I found this, chasing a red check on the unrelated Crowdin PR #4148).Fix
useTranslator()with new catalog keys@astryx.tableTree.expandRow/@astryx.tableTree.collapseRow, mirroring the siblingselectionandrowExpansionplugins.packages/core/locales/en.json.Why it slipped through
#3789's branch predated the #4010 rule and wasn't rebased onto it, so its own CI was green; the violation only surfaced once merged into a
mainthat has the rule.Verification
eslint packages/core/src/Table/plugins/tree/useTableTreeData.tsx→ clean (exit 0)vitest run useTableTreeData useTableTreeState resolve.test→ 75 passedNo changeset — internal lint fix, no runtime package API change.
Refs: #3789, #4010