Skip to content

fix(cli): deduplicate parent and child theme targets - #5767

Merged
cixzhang merged 1 commit into
mainfrom
fix/dedup-table-section-theme
Aug 31, 2026
Merged

fix(cli): deduplicate parent and child theme targets#5767
cixzhang merged 1 commit into
mainfrom
fix/dedup-table-section-theme

Conversation

@cixzhang

@cixzhang cixzhang commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

Why

Theme authors could see duplicate Table section targets because both the Table parent and its child docs correctly expose the same metadata for different lookup paths.

What

  • Preserve direct theming docs for TableHeader, TableBody, and TableFooter.
  • Canonicalize parent/child duplicates in CLI target discovery under the parent owner, while retaining unrelated shared-target rows.
  • Add direct-doc and unfiltered-discovery regression coverage for all three Table sections.
  • Add a CLI patch Changeset.

Risk

CLI metadata discovery only; Table runtime behavior is unchanged.

Testing

  • Full CLI suite: 2,880 tests
  • Focused Table suite: 130 tests
  • CLI strict, authoring, JSON API, template-docs, and core docs typechecks
  • pnpm check:repo

@vercel

vercel Bot commented Aug 31, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
astryx Ready Ready Preview Aug 31, 2026 7:02am

Request Review

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Meta Open Source bot. label Aug 31, 2026
@cixzhang
cixzhang force-pushed the fix/dedup-table-section-theme branch from 2f9c905 to b9ff218 Compare August 31, 2026 06:58
@cixzhang cixzhang changed the title Deduplicate Table section theme metadata fix(cli): deduplicate parent and child theme targets Aug 31, 2026
@cixzhang
cixzhang marked this pull request as ready for review August 31, 2026 07:02
@cixzhang
cixzhang enabled auto-merge (squash) August 31, 2026 07:02
github-actions Bot added a commit that referenced this pull request Aug 31, 2026
@github-actions

Copy link
Copy Markdown
Contributor

PR Analysis Report

📚 Storybook Preview

View Storybook for this PR
GitHub Pages may take up to a minute to hydrate after deploy.

🧪 Sandbox Preview

View Sandbox for this PR
GitHub Pages may take up to a minute to hydrate after deploy.

No new or modified components detected.

Bundle Size Summary

No component packages changed.

Accessibility Audit

Status: No accessibility violations detected.


Generated by PR Enrichment workflow | Storybook | Sandbox | View full report

@cixzhang
cixzhang merged commit 5e8fab8 into main Aug 31, 2026
30 checks passed
@github-actions
github-actions Bot deleted the fix/dedup-table-section-theme branch September 1, 2026 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant