fix(FieldStatus): cover rounded input corners - #5769
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
PR Analysis Report📚 Storybook PreviewView Storybook for this PR 🧪 Sandbox PreviewView Sandbox for this PR Modified ComponentsField (@astryxdesign/core) · View in Storybook
FieldStatus (@astryxdesign/core)
Bundle Size Summary
Accessibility AuditStatus: No accessibility violations detected. Visual Regression8 added · 0 removed. View the report A repository maintainer can accept these exact frames: Generated by PR Enrichment workflow | Storybook | Sandbox | View full report |
cixzhang
left a comment
There was a problem hiding this comment.
Thanks for the fix. In the documented custom/native-control path, clicking the lower half of the input now hits FieldStatus and drops focus to the page. Please keep the attached background from taking pointer input, then retain the size/theme visual coverage.
[Reviewed by Robohands]
cixzhang
left a comment
There was a problem hiding this comment.
Thanks, the click path is fixed. The documented custom/native Field path still paints the attached status over the control instead of behind it: with a pill radius, the lower 20px turns warning yellow, while TextInput stays above the same overlap (Field.tsx:58). Please keep custom controls visually above the status while preserving pointer access, and cover this state in the Field story.
[Reviewed by Robohands]
|
Addressed the latest review feedback:
Focused component tests, RTL coverage tests, strict lint, core build, Storybook production build, knowledge/sync checks, and the repository pre-commit suite pass locally. |
cixzhang
left a comment
There was a problem hiding this comment.
Thanks, the custom-control path now keeps the control above the attached status and preserves focus across the overlap. Focused tests and exact-head visual checks pass.
[Reviewed by Robohands]



Summary
9999pxpill radii remain coveredTest plan
pnpm vitest run packages/core/src/Field/Field.test.tsx packages/core/src/FieldStatus/FieldStatus.test.tsxASTRYX_STRICT_LINT=1 pnpm exec eslint packages/core/src/Field/Field.tsx packages/core/src/Field/Field.test.tsx packages/core/src/FieldStatus/FieldStatus.tsx packages/core/src/FieldStatus/FieldStatus.test.tsxpnpm -F @astryxdesign/core buildpnpm check:repoRelated work
PR #5738 also touches Field and FieldStatus for the separate tooltip-presentation boundary and may require a small rebase depending on merge order.