Skip to content

fix(theme-neutral): correct Banner tint modes - #5936

Merged
rubyycheung merged 1 commit into
mainfrom
fix/neutral-banner-tint-modes
Sep 2, 2026
Merged

fix(theme-neutral): correct Banner tint modes#5936
rubyycheung merged 1 commit into
mainfrom
fix/neutral-banner-tint-modes

Conversation

@rubyycheung

Copy link
Copy Markdown
Contributor

Summary

  • correct the Neutral Banner on-tint values so light mode uses translucent light colors and dark mode uses translucent dark colors
  • keep the maintained theme source, CLI template, and Neutral theme specification aligned
  • add regression coverage for the tint tuple order and Banner token mappings

Testing

  • pnpm exec vitest run packages/themes/neutral/src/neutralTheme.test.ts
  • pnpm -F @astryxdesign/theme-neutral build
  • pnpm exec eslint packages/themes/neutral/src/neutralTheme.ts packages/themes/neutral/src/neutralTheme.test.ts
  • pnpm check:sync
  • pnpm check:knowledge
  • pnpm check:changesets
  • repository pre-commit validation suite

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Meta Open Source bot. label Sep 2, 2026
@vercel

vercel Bot commented Sep 2, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
astryx Ready Ready Preview Sep 2, 2026 8:40pm UTC

Request Review

@rubyycheung
rubyycheung merged commit 2083bb1 into main Sep 2, 2026
23 of 24 checks passed
github-actions Bot added a commit that referenced this pull request Sep 2, 2026
@github-actions
github-actions Bot deleted the fix/neutral-banner-tint-modes branch September 3, 2026 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant