refactor: replace internal isFullBleed usage with padding={0} - #598
Merged
Conversation
Contributor
PR Analysis Report📚 Storybook PreviewView Storybook for this PR 🧪 Sandbox PreviewView Sandbox for this PR Modified ComponentsAppShell · View in Storybook
Layout · View in Storybook
Bundle Size Summary
Accessibility AuditStatus: 1 accessibility violation(s) found — 1 serious. XDSLayout - 1 issue(s)
Generated by PR Enrichment workflow | Storybook | Sandbox | View full report |
cixzhang
force-pushed
the
navi/refactor/remove-isFullBleed
branch
2 times, most recently
from
March 13, 2026 09:48
6a00add to
5ce2142
Compare
cixzhang
force-pushed
the
navi/refactor/remove-isFullBleed
branch
from
March 13, 2026 10:19
5ce2142 to
56fe512
Compare
cixzhang
commented
Mar 13, 2026
| @@ -74,7 +74,7 @@ const meta: Meta<typeof XDSCard> = { | |||
| }, | |||
| isFullBleed: { | |||
Contributor
Author
There was a problem hiding this comment.
We can clean this up
cixzhang
force-pushed
the
navi/refactor/remove-isFullBleed
branch
from
March 13, 2026 10:34
56fe512 to
45f9dfb
Compare
Merged
cixzhang
added a commit
that referenced
this pull request
Apr 26, 2026
cixzhang
added a commit
that referenced
this pull request
Jun 21, 2026
cixzhang
added a commit
that referenced
this pull request
Jun 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two-part refactor that migrates away from
isFullBleedon Layout components and then removes it from their interfaces entirely.Part 1: Replace internal usages with
padding={0}Replace all internal usages of
isFullBleedprop on Layout components with the equivalentpadding={0}. Thepaddingprop is more expressive (supports any spacing step, not just 0/default) and aligns with the rest of the design system API.Files changed:
packages/core/src/AppShell/XDSAppShell.tsx— 4 usages replacedapps/storybook/stories/Layout.stories.tsx— Playground story args/controls migratedapps/storybook/stories/Card.stories.tsx— FullBleed story migrated, deprecation note addedapps/storybook/stories/Section.stories.tsx— FullBleed story migrated, deprecation note addedPart 2: Remove
isFullBleedfrom Layout component interfacesRemove the deprecated
isFullBleedprop from all Layout component interfaces. Consumers must usepadding={0}instead.Files changed:
packages/core/src/Layout/XDSLayout.tsx— removed from props interfacepackages/core/src/Layout/XDSLayoutContent.tsx— removed from props interface and implementationpackages/core/src/Layout/XDSLayoutFooter.tsx— removed from props interface and implementationpackages/core/src/Layout/XDSLayoutHeader.tsx— removed from props interface and implementationpackages/core/src/Layout/XDSLayoutPanel.tsx— removed from props interface and implementationapps/storybook/stories/Layout.stories.tsx— removedisFullBleedargTypeAlso fixed
apps/sandbox/src/app/pages/mega-menu/page.tsx— fixed pre-existing TypeScript error (inline styles position type)What is NOT changed
XDSCardandXDSSection—isFullBleedprop remains (maps topadding={0}internally). Follow-up removal.XDSDivider— itsisFullBleedis a different concept (negative-margin escape hatch)packages/cli/) —migrate-isFullBleed-to-paddingcodemod preserved for consumer migration