Keep CLI search coverage internal - #5994
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
cixzhang
requested review from
imdreamrunner and
josephfarina
as code owners
September 3, 2026 23:03
meta-cla
Bot
added
the
CLA Signed
Contributor
PR Analysis Report📚 Storybook PreviewView Storybook for this PR 🧪 Sandbox PreviewView Sandbox for this PR No new or modified components detected. Bundle Size SummaryNo component packages changed. Accessibility AuditStatus: No accessibility violations detected. Generated by PR Enrichment workflow | Storybook | Sandbox | View full report |
cixzhang
force-pushed
the
fix-search-score-metadata
branch
from
September 3, 2026 23:35
c8c184d to
9663594
Compare
cixzhang
changed the title
cixzhang
commented
Sep 4, 2026
cixzhang
left a comment
cixzhang
left a comment
Contributor
Author
There was a problem hiding this comment.
Semantic verdict: approve
Thanks, this keeps tokenizer coverage private while preserving build's page gate. Exact-phrase, partial-match, declaration-sync, and focused checks are clean.
[Reviewed by Robohands]
This was referenced Sep 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Current main promotes exact multi-word keyword matches but drops internal coverage metadata from that return path. Declaration sync fails, blocking package, sandbox, Storybook, and downstream PR CI.
Coverage is an implementation detail of build's page-quality gate. Exposing tokenizer-derived counts on every public search/build result would create a permanent API contract tied to current ranking mechanics.
What
matchedTerms/queryTermsout of public search and build result shapes and generated declarations.Testing
pnpm -F @astryxdesign/cli sync:api-typespnpm check:repo