feat(Banner): expose root theme target - #6007
Open
freddymeta wants to merge 1 commit into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
github-actions
Bot
requested review from
cvkxx,
ernestt,
kentonquatman and
rubyycheung
September 4, 2026 06:10
Contributor
PR Analysis Report
Modified ComponentsBanner (@astryxdesign/core)
Bundle Size Summary
Accessibility AuditStatus: No accessibility violations detected. Visual RegressionStatus: No visual change across 2 compared shot(s). Generated by PR Enrichment workflow | View full report |
freddymeta
marked this pull request as ready for review
September 4, 2026 16:26
freddymeta
requested review from
cixzhang,
imdreamrunner and
josephfarina
as code owners
September 4, 2026 16:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #6006.
Summary
astryx-banner-rootto the existing outer Banner elementcontainerandelevationon that target for scoped theme rulesThis lets themes set the outer
boxShadowandborderRadiusdirectly instead of relying on Banner's DOM structure.Validation
pnpm lint:strictpnpm exec vitest run --maxWorkers=4pnpm buildpnpm -F @astryxdesign/core typecheckpnpm storybook:buildpnpm a11y:audit -- --components Bannerpnpm rtl:audit -- --filter Bannerpnpm visual:probe-theme:checknode .github/scripts/visual-gate/gate.mjs reach --only core-banner— 8 targets reached, 0 missed