Skip to content

feat(Banner): expose root theme target - #6007

Open
freddymeta wants to merge 1 commit into
mainfrom
feat/banner-root-theme-target
Open

feat(Banner): expose root theme target#6007
freddymeta wants to merge 1 commit into
mainfrom
feat/banner-root-theme-target

Conversation

@freddymeta

Copy link
Copy Markdown
Contributor

Closes #6006.

Summary

  • add astryx-banner-root to the existing outer Banner element
  • reflect container and elevation on that target for scoped theme rules
  • document and generate probe coverage while preserving every existing target and default style
  • record the component's verified RTL non-applicability for the current anatomy

This lets themes set the outer boxShadow and borderRadius directly instead of relying on Banner's DOM structure.

Validation

  • pnpm lint:strict
  • pnpm exec vitest run --maxWorkers=4
  • pnpm build
  • pnpm -F @astryxdesign/core typecheck
  • pnpm storybook:build
  • pnpm a11y:audit -- --components Banner
  • pnpm rtl:audit -- --filter Banner
  • pnpm visual:probe-theme:check
  • node .github/scripts/visual-gate/gate.mjs reach --only core-banner — 8 targets reached, 0 missed

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Meta Open Source bot. label Sep 4, 2026
@vercel

vercel Bot commented Sep 4, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
astryx Ready Ready Preview Sep 4, 2026 6:13am UTC

Request Review

@github-actions github-actions Bot added community Authored by a community contributor (not on the eng/design team) needs:code-review High-risk change (new package/component/API) — needs human code review before merge needs:design-review Affects visuals — Design should review labels Sep 4, 2026
github-actions Bot added a commit that referenced this pull request Sep 4, 2026
@github-actions

github-actions Bot commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

PR Analysis Report

Preview availability: Storybook and Sandbox were not published for this CI run.

Modified Components

Banner (@astryxdesign/core)
Metric Before After Delta
Bundle Size (ESM) N/A N/A N/A
Lines of Code N/A 428 -
Complexity N/A Very High (44) -

Bundle Size Summary

Package Size (ESM) Size (CJS) Gzipped
@astryxdesign/core N/A 4.8KB 1.2KB

Accessibility Audit

Status: No accessibility violations detected.

Visual Regression

Status: No visual change across 2 compared shot(s).


Generated by PR Enrichment workflow | View full report

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Meta Open Source bot. community Authored by a community contributor (not on the eng/design team) needs:code-review High-risk change (new package/component/API) — needs human code review before merge needs:design-review Affects visuals — Design should review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Banner outer elevation and radius are not theme-targetable

1 participant