fix(Button): hardening — swarm findings - #765
Merged
Merged
Conversation
meta-cla
Bot
added
the
CLA Signed
josephfarina
force-pushed
the
navi/hardening/button
branch
2 times, most recently
from
March 23, 2026 22:47
ea3d4d3 to
0c586f6
Compare
josephfarina
force-pushed
the
navi/hardening/button
branch
5 times, most recently
from
March 23, 2026 23:57
bd94880 to
dfa6178
Compare
josephfarina
force-pushed
the
navi/hardening/button
branch
from
March 24, 2026 00:01
dfa6178 to
537b36e
Compare
josephfarina
marked this pull request as ready for review
March 24, 2026 00:01
Contributor
PR Analysis Report📚 Storybook PreviewView Storybook for this PR 🧪 Sandbox PreviewView Sandbox for this PR Modified ComponentsButton · View in Storybook
Layout · View in Storybook
MoreMenu · View in Storybook
Bundle Size Summary
Accessibility AuditStatus: 1 accessibility violation(s) found — 1 serious. XDSLayout - 1 issue(s)
Generated by PR Enrichment workflow | Storybook | Sandbox | View full report |
cixzhang
pushed a commit
that referenced
this pull request
Apr 26, 2026
* fix(Button): hardening — swarm findings * fix(Button): swarm fixes — verified findings * review: restore name/value/form props removed by hardening (no breaking changes) --------- Co-authored-by: Joey Farina <joeyfarina@fb.com>
cixzhang
pushed a commit
that referenced
this pull request
Jun 21, 2026
* fix(Button): hardening — swarm findings * fix(Button): swarm fixes — verified findings * review: restore name/value/form props removed by hardening (no breaking changes) --------- Co-authored-by: Joey Farina <joeyfarina@fb.com>
cixzhang
pushed a commit
that referenced
this pull request
Jun 21, 2026
* fix(Button): hardening — swarm findings * fix(Button): swarm fixes — verified findings * review: restore name/value/form props removed by hardening (no breaking changes) --------- Co-authored-by: Joey Farina <joeyfarina@fb.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hardening fixes for XDSButton based on CC review.
Changes
type="button"default — prevents accidental form submissionprefers-reduced-motionon transitionsaria-disabledinstead of nativedisabledwhen tooltip is present (keeps button focusable for tooltip keyboard access), with Enter/Space key suppressionbackgroundImage: noneon:hoverand:activefor aria-disabled state (prevents gradient flash)actionInFlightReffor asynconClickActiononClickfires beforeonClickActionso consumers canpreventDefault()to cancel the actionaria-hiddenon content + spinner, live region announces Loading--button-focus-offset,--button-icon-only-aspectScreenshots