fix(Switch): hardening — swarm findings - #768
Merged
Merged
Conversation
meta-cla
Bot
added
the
CLA Signed
josephfarina
force-pushed
the
navi/hardening/switch
branch
from
March 23, 2026 19:18
e497bd3 to
69a87bc
Compare
josephfarina
marked this pull request as ready for review
March 23, 2026 21:54
Contributor
PR Analysis Report📚 Storybook PreviewView Storybook for this PR 🧪 Sandbox PreviewView Sandbox for this PR Modified ComponentsSwitch · View in Storybook
Bundle Size Summary
Accessibility AuditStatus: No accessibility violations detected. Generated by PR Enrichment workflow | Storybook | Sandbox | View full report |
cixzhang
pushed a commit
that referenced
this pull request
Apr 26, 2026
* fix(Switch): hardening — swarm findings * fix(Switch): swarm fixes — verified findings * fix(Switch): center label block and trim noisy tests * fix(Switch): remove process.env check (no @types/node in CI) --------- Co-authored-by: Joey Farina <joeyfarina@fb.com>
cixzhang
pushed a commit
that referenced
this pull request
Jun 21, 2026
* fix(Switch): hardening — swarm findings * fix(Switch): swarm fixes — verified findings * fix(Switch): center label block and trim noisy tests * fix(Switch): remove process.env check (no @types/node in CI) --------- Co-authored-by: Joey Farina <joeyfarina@fb.com>
cixzhang
pushed a commit
that referenced
this pull request
Jun 21, 2026
* fix(Switch): hardening — swarm findings * fix(Switch): swarm fixes — verified findings * fix(Switch): center label block and trim noisy tests * fix(Switch): remove process.env check (no @types/node in CI) --------- Co-authored-by: Joey Farina <joeyfarina@fb.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hardening: Switch (#718)
Fixes from swarm audit: reduced-motion media query, isBusy guard, description typography, xdsClassName variants, layout centering fix.
Changes
container:alignItems: center(wasflex-start)labelWrapper: removedmarginTop: 3hack, addedjustifyContent: center+minHeight: SWITCH_HEIGHTScreenshots