fix(CheckboxInput): hardening — swarm findings - #769
Merged
Conversation
meta-cla
Bot
added
the
CLA Signed
This comment was marked as resolved.
This comment was marked as resolved.
- Extend XDSBaseProps (adds xstyle, className, style)
- Wire up mergeProps on root div and visual checkbox
- Add xdsClassName('checkbox') on visual checkbox for theme targeting
- Guard onChange when isBusy (prevents double-action during async)
- Add prefers-reduced-motion on checkbox transition (0.01s)
- Add lineHeight and fontWeight to description style
- Center checkbox with label+description (alignItems center, remove marginTop nudges)
- Remove dead labelWrapperSizeStyles
- Fix ref JSDoc
- Update docs: add 10 missing props, fix sibling->ancestor selector note,
add features for async/status/sizes, update all three doc exports
Hardening: #718
josephfarina
force-pushed
the
navi/hardening/checkboxinput
branch
from
March 23, 2026 23:05
f2f56f2 to
33bcebc
Compare
Contributor
PR Analysis Report📚 Storybook PreviewView Storybook for this PR 🧪 Sandbox PreviewView Sandbox for this PR Modified ComponentsCheckboxInput · View in Storybook
Bundle Size Summary
Accessibility AuditStatus: No accessibility violations detected. Generated by PR Enrichment workflow | Storybook | Sandbox | View full report |
josephfarina
force-pushed
the
navi/hardening/checkboxinput
branch
5 times, most recently
from
March 23, 2026 23:27
3788afe to
cd85012
Compare
josephfarina
force-pushed
the
navi/hardening/checkboxinput
branch
from
March 23, 2026 23:37
cd85012 to
3624bb9
Compare
josephfarina
marked this pull request as ready for review
March 23, 2026 23:40
cixzhang
pushed a commit
that referenced
this pull request
Apr 26, 2026
* fix(CheckboxInput): hardening — swarm findings
- Extend XDSBaseProps (adds xstyle, className, style)
- Wire up mergeProps on root div and visual checkbox
- Add xdsClassName('checkbox') on visual checkbox for theme targeting
- Guard onChange when isBusy (prevents double-action during async)
- Add prefers-reduced-motion on checkbox transition (0.01s)
- Add lineHeight and fontWeight to description style
- Center checkbox with label+description (alignItems center, remove marginTop nudges)
- Remove dead labelWrapperSizeStyles
- Fix ref JSDoc
- Update docs: add 10 missing props, fix sibling->ancestor selector note,
add features for async/status/sizes, update all three doc exports
Hardening: #718
* use 0s instead of 0.01s for reduced-motion duration
cixzhang
pushed a commit
that referenced
this pull request
Jun 21, 2026
* fix(CheckboxInput): hardening — swarm findings
- Extend XDSBaseProps (adds xstyle, className, style)
- Wire up mergeProps on root div and visual checkbox
- Add xdsClassName('checkbox') on visual checkbox for theme targeting
- Guard onChange when isBusy (prevents double-action during async)
- Add prefers-reduced-motion on checkbox transition (0.01s)
- Add lineHeight and fontWeight to description style
- Center checkbox with label+description (alignItems center, remove marginTop nudges)
- Remove dead labelWrapperSizeStyles
- Fix ref JSDoc
- Update docs: add 10 missing props, fix sibling->ancestor selector note,
add features for async/status/sizes, update all three doc exports
Hardening: #718
* use 0s instead of 0.01s for reduced-motion duration
cixzhang
pushed a commit
that referenced
this pull request
Jun 21, 2026
* fix(CheckboxInput): hardening — swarm findings
- Extend XDSBaseProps (adds xstyle, className, style)
- Wire up mergeProps on root div and visual checkbox
- Add xdsClassName('checkbox') on visual checkbox for theme targeting
- Guard onChange when isBusy (prevents double-action during async)
- Add prefers-reduced-motion on checkbox transition (0.01s)
- Add lineHeight and fontWeight to description style
- Center checkbox with label+description (alignItems center, remove marginTop nudges)
- Remove dead labelWrapperSizeStyles
- Fix ref JSDoc
- Update docs: add 10 missing props, fix sibling->ancestor selector note,
add features for async/status/sizes, update all three doc exports
Hardening: #718
* use 0s instead of 0.01s for reduced-motion duration
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hardening fixes for CheckboxInput based on CC review.
Changes
typeScaleVars→textSizeVars, addlineHeightandfontWeightto description styleinput.indeterminateDOM property via callback ref (screen readers like NVDA/JAWS read the native property, not justaria-checked)xdsClassName(CSS can target:checked/:disabledpseudo-classes directly)Screenshots