fix(DateInput): hardening — swarm findings - #772
Merged
Conversation
Contributor
PR Analysis Report📚 Storybook PreviewView Storybook for this PR 🧪 Sandbox PreviewView Sandbox for this PR Modified ComponentsDateInput · View in Storybook
Bundle Size Summary
Accessibility AuditStatus: No accessibility violations detected. Generated by PR Enrichment workflow | Storybook | Sandbox | View full report |
cixzhang
reviewed
Mar 21, 2026
josephfarina
force-pushed
the
navi/hardening/dateinput
branch
3 times, most recently
from
March 24, 2026 19:35
6f5c002 to
dd9d245
Compare
josephfarina
marked this pull request as ready for review
March 24, 2026 19:39
josephfarina
force-pushed
the
navi/hardening/dateinput
branch
from
March 24, 2026 20:34
dd9d245 to
77b3124
Compare
Contributor
Author
|
Removed the ArrowDown shortcut and its test per Cindy's review. Good call, it was incomplete without focus management into the calendar grid. |
cixzhang
pushed a commit
that referenced
this pull request
Apr 26, 2026
* fix(DateInput): hardening — swarm findings * fix(DateInput): swarm fixes — verified findings * review: apply API guidance per Cindy review * cleanup: strip noise from hardening PR * test(DateInput): add failing tests for parser bugs and keyboard handling * fix(DateInput): parser bugs + keyboard handling --------- Co-authored-by: Joey Farina <joeyfarina@fb.com>
cixzhang
pushed a commit
that referenced
this pull request
Jun 21, 2026
* fix(DateInput): hardening — swarm findings * fix(DateInput): swarm fixes — verified findings * review: apply API guidance per Cindy review * cleanup: strip noise from hardening PR * test(DateInput): add failing tests for parser bugs and keyboard handling * fix(DateInput): parser bugs + keyboard handling --------- Co-authored-by: Joey Farina <joeyfarina@fb.com>
cixzhang
pushed a commit
that referenced
this pull request
Jun 21, 2026
* fix(DateInput): hardening — swarm findings * fix(DateInput): swarm fixes — verified findings * review: apply API guidance per Cindy review * cleanup: strip noise from hardening PR * test(DateInput): add failing tests for parser bugs and keyboard handling * fix(DateInput): parser bugs + keyboard handling --------- Co-authored-by: Joey Farina <joeyfarina@fb.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hardening fixes for XDSDateInput and dateParser.
Changes
DateInput component
isEffectivelyDisabled: input disabled during isBusy (prevents interaction during async updates)isDateDisabled(previously only calendar enforced min/max)role="combobox",aria-expanded,aria-haspopup="dialog",aria-controlsoptimisticValueinstead of stalevaluedateParser
date.setFullYear(year)after construction)1/25.2026→ null)dateToISOTests
Screenshots