fix(Button): prevent text wrap in constrained layouts - #892
Merged
Conversation
meta-cla
Bot
added
the
CLA Signed
Contributor
PR Analysis Report📚 Storybook PreviewView Storybook for this PR 🧪 Sandbox PreviewView Sandbox for this PR Modified ComponentsButton · View in Storybook
Bundle Size Summary
Accessibility AuditStatus: No accessibility violations detected. Generated by PR Enrichment workflow | Storybook | Sandbox | View full report |
Add whiteSpace: 'nowrap' to button base styles so text never wraps to a second line. Wrap the label text in a span with overflow: hidden and textOverflow: ellipsis so constrained buttons truncate gracefully instead of clipping silently. Adds a Truncation story demonstrating the behavior at various widths. Co-authored-by: Navi <navi@navibot.dev>
cixzhang
force-pushed
the
navi/fix/button-text-nowrap
branch
from
March 25, 2026 23:58
9a3d6ab to
f98a6dc
Compare
cixzhang
added a commit
that referenced
this pull request
Apr 26, 2026
Add whiteSpace: 'nowrap' to button base styles so text never wraps to a second line. Wrap the label text in a span with overflow: hidden and textOverflow: ellipsis so constrained buttons truncate gracefully instead of clipping silently. Adds a Truncation story demonstrating the behavior at various widths. Co-authored-by: Navi <navi@users.noreply.github.com>
cixzhang
added a commit
that referenced
this pull request
Jun 21, 2026
Add whiteSpace: 'nowrap' to button base styles so text never wraps to a second line. Wrap the label text in a span with overflow: hidden and textOverflow: ellipsis so constrained buttons truncate gracefully instead of clipping silently. Adds a Truncation story demonstrating the behavior at various widths. Co-authored-by: Navi <navi@users.noreply.github.com>
cixzhang
added a commit
that referenced
this pull request
Jun 21, 2026
Add whiteSpace: 'nowrap' to button base styles so text never wraps to a second line. Wrap the label text in a span with overflow: hidden and textOverflow: ellipsis so constrained buttons truncate gracefully instead of clipping silently. Adds a Truncation story demonstrating the behavior at various widths.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Button text wraps to a second line when placed in constrained flex layouts, causing the icon to appear disproportionately large.
Spotted by @cixzhang in #888 — the "New item" button in the WithActions TabList story wraps at narrow viewports:
Fix
Two changes to the button base styles:
whiteSpace: 'nowrap'on the button container — prevents text from wrapping to a second lineoverflow: hidden+textOverflow: ellipsis— so constrained buttons truncate with an ellipsis instead of clipping silentlyStory
Adds a
Truncationstory toCore/XDSButtondemonstrating: