This repository was archived by the owner on Nov 10, 2023. It is now read-only.
Ensure onCreate calls through to super onCreate#53
Closed
georgepapas wants to merge 1 commit intofacebook:masterfrom
Closed
Ensure onCreate calls through to super onCreate#53georgepapas wants to merge 1 commit intofacebook:masterfrom
georgepapas wants to merge 1 commit intofacebook:masterfrom
Conversation
Contributor
|
Can you rebase and sign the Facebook Contributors License Agreement @ http://developers.facebook.com/opensource/cla ? You don't need a Facebook account to sign. FYI, we adopted the Apache Software Foundation's CLA which is also used by Google, RedHat, Zend, and others. |
Contributor
Author
|
Hi, Signed agreement, branch is up to date. Thanks |
Contributor
|
Awesome! We'll work on merging this asap. |
bolinfest
pushed a commit
that referenced
this pull request
Nov 20, 2013
Summary: Quick Start docs create an activity that does not call through to super.onCreate and causes the sample Hello World app to crash. #53 Test Plan: http://localhost:9811/setup/manual_quick_start.html
Contributor
|
Patched as 10f50e2. |
Contributor
|
@georgepapas updated the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Quick start doco creates an activity which does not call through to super.onCreate and causes the sample Hello World app to crash.