Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update webpack-dev-server to 3.2.1 #6483

Merged
merged 2 commits into from Mar 9, 2019

Conversation

@ThePrez
Copy link
Contributor

commented Feb 21, 2019

This PR is a simple request to upgrade the version of webpack-dev-server, which adds support for the IBM i platform and AIX.

Currently, the install of react-scripts fails because of an old version of internal-ip that was not installable on these platforms. webpack-dev-server was updated in this PR: webpack/webpack-dev-server#1668 which landed in 3.2.0

@facebook-github-bot

This comment has been minimized.

Copy link

commented Feb 21, 2019

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot

This comment has been minimized.

Copy link

commented Feb 21, 2019

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@ianschmitz

This comment has been minimized.

Copy link
Collaborator

commented Feb 21, 2019

It sounds like we'll want to wait for webpack/webpack-dev-server#1676 to be released and upgrade when that fix is in.

@ThePrez

This comment has been minimized.

Copy link
Contributor Author

commented Feb 21, 2019

@ianschmitz, I agree with that assessment. Thanks!

@patrickhrastnik

This comment has been minimized.

Copy link

commented Feb 22, 2019

Same as #6478

@ThePrez

This comment has been minimized.

Copy link
Contributor Author

commented Feb 22, 2019

Closing this PR for now due to issues in the default-gateway changes with npm ci
silverwind/default-gateway#5
silverwind/default-gateway#10
Let's wait for that to be sorted out also.

@ThePrez ThePrez closed this Feb 22, 2019

@ThePrez ThePrez changed the title Update webpack-dev-server to 3.2.0 Update webpack-dev-server to 3.2.1 Feb 25, 2019

@ThePrez ThePrez reopened this Feb 25, 2019

@ThePrez

This comment has been minimized.

Copy link
Contributor Author

commented Feb 25, 2019

Reopening now that webpack/webpack-dev-server#1676 has landed in version 3.2.1

@ianschmitz ianschmitz added this to the 2.1.6 milestone Feb 26, 2019

@iansu iansu modified the milestones: 2.1.6, 2.1.x Mar 6, 2019

@ianschmitz ianschmitz modified the milestones: 2.1.x, 2.1.9 Mar 9, 2019

@ianschmitz ianschmitz merged commit c54e36d into facebook:master Mar 9, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ianschmitz

This comment has been minimized.

Copy link
Collaborator

commented Mar 9, 2019

Thanks!

ericclemmons added a commit to ericclemmons/create-react-app that referenced this pull request Mar 10, 2019

Merge branch 'master' of github.com:facebook/create-react-app into PU…
…BLIC_URL-in-development

* 'master' of github.com:facebook/create-react-app: (58 commits)
  Update webpack-dev-server to 3.2.1 (facebook#6483)
  [docs] revert removal of newlines from html (facebook#6386)
  Publish
  Prepare 2.1.8 release
  Reapply "Speed up TypeScript v2 (facebook#6406)" (facebook#6586)
  Publish
  Prepare 2.1.7 release
  Revert "Speed up TypeScript v2 (facebook#6406)" (facebook#6585)
  Publish
  Prepare 2.1.6 release
  Fix build deployment instruction link appends comma at end (facebook#6511)
  Remove AppVeyor config files (facebook#6493)
  removed redundant statements (facebook#6254)
  Improved language used in markdown code blocks. (facebook#6419)
  minor typo fix in openBrowser
  Analyse also dependencies bundle (facebook#6438)
  Fix a typo
  Use contenthash instead of chunkhash for better long-term caching (facebook#6387)
  Remove latest Node version from Travis config (facebook#6474)
  revert css sourcemaps in development (facebook#6472)
  ...

# Conflicts:
#	packages/react-scripts/scripts/start.js

@iansu iansu modified the milestones: 2.1.9, 3.0 Mar 10, 2019

@iansu iansu added this to Done in v3 Mar 10, 2019

JoviDeCroock added a commit to JoviDeCroock/create-react-app that referenced this pull request Mar 15, 2019

Merge branch 'masterd' into feat/modern-build
* masterd: (24 commits)
  Add TypeScript linting support (facebook#6513)
  Support React Hooks (facebook#5602) (facebook#5997)
  Support browserslist in @babel/preset-env (facebook#6608)
  Add empty mock for http2 (facebook#5686)
  Add note about npx caching (facebook#6374)
  change named import into default import (facebook#6625)
  Stage files for commit after ejecting (facebook#5960)
  Upgrade dependencies (facebook#6614)
  Make compiler variable const instead of let (facebook#6621)
  Type check JSON files (facebook#6615)
  Change class components to functional components in templates (facebook#6451)
  Convert JSON.stringify \n to os.EOL when writing tsconfig.json (facebook#6610)
  Update html-webpack-plugin (facebook#6361)
  Enable click to go to error in console for TypeScript (facebook#6502)
  Update webpack-dev-server to 3.2.1 (facebook#6483)
  [docs] revert removal of newlines from html (facebook#6386)
  Publish
  Prepare 2.1.8 release
  Reapply "Speed up TypeScript v2 (facebook#6406)" (facebook#6586)
  Publish
  ...

# Conflicts:
#	packages/babel-preset-react-app/create.js
#	packages/react-scripts/scripts/build.js

@lock lock bot locked and limited conversation to collaborators Mar 15, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
5 participants
You can’t perform that action at this time.