fix(content-blog): fix wrong path variable in feed XSLT CSS file validation#11736
Merged
slorber merged 1 commit intofacebook:mainfrom Feb 13, 2026
Merged
Conversation
✅ [V2]Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
Collaborator
|
thanks 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-flight checklist
requests.
verify the new behavior.
and the maintainers have approved on my working plan.
Motivation
In
resolveXsltFilePathsinsidepackages/docusaurus-plugin-content-blog/src/feed.ts, there are twosequential existence checks:
xsltAbsolutePathxsltAbsolutePathThe 2nd check should use
cssAbsolutePath. Because it rechecks the XSLT path (which already passedthe first check), the CSS validation never fails ;even when the CSS file is genuinely missing. The
downstream
fs.copy(cssAbsolutePath, ...)at line 252 then crashes with an unhelpful filesystem errorinstead of the err message that was written for this exact scenario.
Test Plan
1.)the logic is straightforward.
2.)The function is called once by
generateXsltFiles(line 242), which destructures{xsltAbsolutePath, cssAbsolutePath}and copies both files. With this fix, a missing CSS file is now caught at validationtime with the intended error message instead of failing silently until the copy step.
Test links
N/A — no UI change.
Related issues/PRs
None - analyis of file