Skip to content

fix(google-tag-manager): rename pluginGoogleAnalytics to pluginGoogleTagManager#11739

Merged
slorber merged 1 commit intofacebook:mainfrom
akshatsinha0:fix/google-tag-manager-function-name
Feb 19, 2026
Merged

fix(google-tag-manager): rename pluginGoogleAnalytics to pluginGoogleTagManager#11739
slorber merged 1 commit intofacebook:mainfrom
akshatsinha0:fix/google-tag-manager-function-name

Conversation

@akshatsinha0
Copy link
Copy Markdown
Contributor

Pre-flight checklist

  • I have read the Contributing Guidelines on pull requests.
  • If this is a code change: I have written unit tests and/or added dogfooding pages to fully verify the new behavior.
  • If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

The default export function in docusaurus-plugin-google-tag-manager/src/index.ts is named
pluginGoogleAnalytics. This is a copy-paste artifact from docusaurus-plugin-google-analytics, where
that name is correct.

The other two Google plugins follow the correct naming convention:
- docusaurus-plugin-google-analytics -> pluginGoogleAnalytics
- docusaurus-plugin-google-gtag -> pluginGoogleGtag
- docusaurus-plugin-google-tag-manager -> pluginGoogleAnalytics {wrong}

The plugin's name property already returns the correct string
'docusaurus-plugin-google-tag-manager'. Only the function identifier we looked into.

Test Plan

- No behavioral change. The function is a default export, so no external code references it by name.  

Verified that no other file in therepo imports this function by identifier.

Test links

Deploy preview: https://deploy-preview-_____--docusaurus-2.netlify.app/

Related issues/PRs

N/A

@meta-cla meta-cla Bot added the CLA Signed Signed Facebook CLA label Feb 14, 2026
@netlify
Copy link
Copy Markdown

netlify Bot commented Feb 14, 2026

[V2]

Built without sensitive environment variables

Name Link
🔨 Latest commit af714aa
🔍 Latest deploy log https://app.netlify.com/projects/docusaurus-2/deploys/69904743cd9abc0008816b88
😎 Deploy Preview https://deploy-preview-11739--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@slorber slorber changed the title Fix(google-tag-manager): rename pluginGoogleAnalytics to pluginGoogleTagManager fix(google-tag-manager): rename pluginGoogleAnalytics to pluginGoogleTagManager Feb 19, 2026
@slorber slorber added the pr: ignore This PR is not meaningful enough to appear in the changelog. label Feb 19, 2026
@slorber slorber merged commit 84fb4dc into facebook:main Feb 19, 2026
45 of 46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Signed Facebook CLA pr: ignore This PR is not meaningful enough to appear in the changelog.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants