You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As I suspected (I don't have admin permissions), the "main" branch is protected, even from GitHub Actions commits
So the release workflow running on main can't push updates to package.json: not a big deal because I'm not 100% convinced it should. However, we can still push the git tag, useful to create the GitHub release.
I guess it only makes sense to change package.json version of our monorepo source files when we release a new major/minor version. It's probably useless for patch/prereleases/canary and can be a source of Git merge conflict if done too often.
We'll see when/how we'll update those package.json versions in the future, but it probably makes sense to do them in the same PR that handles a major/minor version, alongside the blog post, docs version cut etc...
Lerna has a command we can run as part of our release process to bump all the public package versions:
yarn lerna version 3.0.0 --exact --no-push --yes
This PR also
cleans up a TODO I forgot
revert commit of preprease version number in package.json
fix canary version number because I'm not sure how useful it would be to include the prerelease (if we ever commit it to main anyway): 3.9.2-alpha.1-canary-6539 ➡️ 3.9.2-canary-6539
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLA SignedSigned Facebook CLApr: maintenanceThis PR does not produce any behavior differences to end users when upgrading.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
slorber
added
the
pr: maintenance
Motivation
Follow up of #11819
As I suspected (I don't have admin permissions), the "main" branch is protected, even from GitHub Actions commits
So the release workflow running on
maincan't push updates topackage.json: not a big deal because I'm not 100% convinced it should. However, we can still push the git tag, useful to create the GitHub release.I guess it only makes sense to change
package.jsonversion of our monorepo source files when we release a new major/minor version. It's probably useless for patch/prereleases/canary and can be a source of Git merge conflict if done too often.We'll see when/how we'll update those
package.jsonversions in the future, but it probably makes sense to do them in the same PR that handles a major/minor version, alongside the blog post, docs version cut etc...Lerna has a command we can run as part of our release process to bump all the public package versions:
This PR also
3.9.2-alpha.1-canary-6539➡️3.9.2-canary-6539Test Plan
CI + manual workflow dispatch