chore(pwa-plugin): upgrade workbox, force fix security warning about serialize-javascript#11995
Merged
Merged
Conversation
slorber
added
the
pr: maintenance
✅ [V2]
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Size Change: 0 B Total Size: 12 MB ℹ️ View Unchanged
|
⚡️ Lighthouse report for the deploy preview of this PR
|
|
Size Change: 0 B Total Size: 12.5 MB ℹ️ View Unchanged
|
slorber
changed the title
serialize-javascriptserialize-javascript
|
@slorber note that this update changes the templating engine used by |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Fix #11801
Workbox new release doesn't pull a transitive dependency that triggers a security warning: GoogleChrome/workbox#3470
Technically, we don't need to update the semver range since it's compatible already.
However let's force upgrade our community automatically, and our own deps in the same occasion.
Not really needed to backport in v3, thanks to semver range compatibility: v3 users can automatically get the fix on deps upgrades.
Test Plan
CI
Test links
https://deploy-preview-11995--docusaurus-2.netlify.app/