chore(monorepo): upgrade monorepo to ESLint 9#12024
Merged
Merged
Conversation
slorber
added
the
pr: maintenance
…rber/upgrade-eslint # Conflicts: # eslint.config.backup.js
✅ [V2]
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Size Change: 0 B Total Size: 12 MB ℹ️ View Unchanged
|
⚡️ Lighthouse report for the deploy preview of this PR
|
|
Size Change: 0 B Total Size: 12.5 MB ℹ️ View Unchanged
|
slorber
changed the title
|
All alerts resolved. Learn more about Socket for GitHub. This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. |
Collaborator
Author
|
Yarn PnP error is unrelated, see #12025 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Upgrade from ESLint 8 (unmaintained) to ESLint 9
Note that:
For now, adopting ESLint 9 with the new flat config is enough
Note: our Docusaurus ESLint plugin isn't modified and remains compatible with ESLint 8, as of #12025
Future
In the future, we'll consider oxlint as a faster alternative. Our rules are quite messy currently, and it's probably ok to start again from a fresh start. This is not urgent and can be worked on later.
Test Plan
CI