chore(ci): Fix Node ERR_INTERNAL_ASSERTION error under Yarn PnP #12048
Merged
Conversation
Collaborator
Author
|
cc @arcanis @mcollina we have an I have no idea how/where to report the problem and who is more likely to handle it, so let me know if you have any insight. Thanks. I suspect that it's related a async function read() {
if (await fileExists('package.json')) {
return require('package.json')
}
return undefined;
}
await Promise.all([
read(),
read()
])Assertion failing: https://github.com/nodejs/node/blob/a29a11864b73fe55e96dd6969602ca1990611d4f/lib/internal/modules/esm/translators.js#L153 No idea why it only fails on PnP, though. |
✅ [V2]
To edit notification comments on pull requests, go to your Netlify project configuration. |
slorber
added
the
pr: ignore
|
Size Change: 0 B Total Size: 12 MB ℹ️ View Unchanged
|
⚡️ Lighthouse report for the deploy preview of this PR
|
|
Size Change: 0 B Total Size: 12.5 MB ℹ️ View Unchanged
|
slorber
changed the title
ERR_INTERNAL_ASSERTIONERR_INTERNAL_ASSERTION error under Yarn PnP
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
https://github.com/facebook/docusaurus/actions/runs/26220488585/job/77153903680?pr=12046
For unknown reasons, we started getting these weird errors under Yarn PnP on our CI.
I don't know if it's related to a Yarn or Node release, and even if it makes sense to report those, given I don't really have a clear minimal repro apart from our full monorepo setup + e2e test suite.
I'm just going to try rewriting a bit the code until this pass.
Test Plan
CI
Test links
https://deploy-preview-12048--docusaurus-2.netlify.app/