refactor(v2): determine all available routes/url#1264
Merged
Conversation
Contributor
|
Deploy preview for docusaurus-preview ready! Built with commit bf8d973 |
Contributor
|
Deploy preview for docusaurus-preview ready! Built with commit 343de97 |
Contributor
|
Deploy preview for docusaurus-preview ready! Built with commit f1bdd6b |
Contributor
|
Deploy preview for docusaurus-preview ready! Built with commit f2bce8c |
yangshun
approved these changes
Mar 6, 2019
yangshun
left a comment
yangshun
left a comment
Contributor
There was a problem hiding this comment.
Wow, this is great! Thanks for helping me resolve one TODO 😄
| * LICENSE file in the root directory of this source tree. | ||
| */ | ||
|
|
||
| const _ = require('lodash'); |
Contributor
There was a problem hiding this comment.
Technically we can now remove lodash from the package.json but let's keep it around as I think it will be useful in future.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
We can determine all available routes/urls when building the react-router config. So let's do that
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Locally debug the routesPaths value and add small test