docs: showcase user Testing Library #1416
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Deploy preview for docusaurus-2 ready! Built with commit 2be474f |
Contributor
|
Deploy preview for docusaurus-preview ready! Built with commit 2be474f |
yangshun
suggested changes
Apr 29, 2019
Contributor
There was a problem hiding this comment.
You'll have to ask for permissions on their repo first - https://github.com/testing-library/testing-library-docs/issues
Also, let's copy their logo image in use a local filesystem one.
|
You have a 👍 from me! |
Contributor
|
Wow that was a fast reply, thanks @kentcdodds! |
Contributor
Author
|
I asked testing-library/testing-library-docs#96 and wait for the response. I will ask them before creating PR next time. |
Contributor
Author
|
@yangshun They accepted. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Have you read the Contributing Guidelines on pull requests?
Yes