Skip to content

docs(v2): proofread docs for alpha.20#1658

Merged
yangshun merged 4 commits intomasterfrom
update-docs
Jul 14, 2019
Merged

docs(v2): proofread docs for alpha.20#1658
yangshun merged 4 commits intomasterfrom
update-docs

Conversation

@yangshun
Copy link
Copy Markdown
Contributor

Motivation

  • Change headings from Title Case to Sentence case
  • Proofread directory structure for new /src/ directory
  • Fix a few typos

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

See Netlify

Related PRs

(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)

@yangshun yangshun requested a review from endiliey as a code owner July 13, 2019 20:22
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Jul 13, 2019
@yangshun
Copy link
Copy Markdown
Contributor Author

@wgao19 this will conflict with #1645 (I renamed a file) but I guess it's not too big of a deal as that PR doesn't contain too many things yet.

@docusaurus-bot
Copy link
Copy Markdown
Contributor

docusaurus-bot commented Jul 13, 2019

Deploy preview for docusaurus-2 ready!

Built with commit 4736cfe

https://deploy-preview-1658--docusaurus-2.netlify.com

@docusaurus-bot
Copy link
Copy Markdown
Contributor

docusaurus-bot commented Jul 13, 2019

Deploy preview for docusaurus-preview ready!

Built with commit 4736cfe

https://deploy-preview-1658--docusaurus-preview.netlify.com

Comment thread website/docs/creating-pages.md Outdated
│ └── pages
│ ├── styles.module.css
│ └── index.js
│ └── support
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be parallel to index.js right?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right. Good catch!

Comment thread website/docs/creating-pages.md Outdated
@wgao19
Copy link
Copy Markdown
Contributor

wgao19 commented Jul 14, 2019

This is neat, thank you!

@wgao19
Copy link
Copy Markdown
Contributor

wgao19 commented Jul 14, 2019

Referencing #1640

@yangshun yangshun merged commit c021367 into master Jul 14, 2019
@yangshun yangshun deleted the update-docs branch July 14, 2019 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Signed Facebook CLA

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants