Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(v2): contributing for v2 #1700

Merged
merged 2 commits into from Jul 25, 2019

Conversation

@wgao19
Copy link
Collaborator

commented Jul 25, 2019

Motivation

Addressing #1640, add docs for contributing for v2.

Copied over CONTRIBUTING.md from root and reorganized for v2.

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Bonus points for screenshots and videos!)

NA

Related PRs

(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)

#1640

@wgao19 wgao19 requested review from endiliey and yangshun as code owners Jul 25, 2019

@wgao19 wgao19 referenced this pull request Jul 25, 2019
12 of 19 tasks complete
@docusaurus-bot

This comment has been minimized.

Copy link
Collaborator

commented Jul 25, 2019

Deploy preview for docusaurus-2 ready!

Built with commit 3c29c45

https://deploy-preview-1700--docusaurus-2.netlify.com

@docusaurus-bot

This comment has been minimized.

Copy link
Collaborator

commented Jul 25, 2019

Deploy preview for docusaurus-preview ready!

Built with commit 3c29c45

https://deploy-preview-1700--docusaurus-preview.netlify.com

@endiliey
Copy link
Collaborator

left a comment

small nits otherwise lgtm we can tweak more in the future. i plan to write some docs maybe this week


- Start using Docusaurus 2! Go through the [Getting Started](installation.md) guides. Does everything work as expected? If not, we're always looking for improvements. Let us know by [opening an issue](#reporting-new-issues).
- Look through the [v2.0 issues](https://github.com/facebook/docusaurus/labels/2.x). If you find an issue you would like to fix, [open a pull request](#your-first-pull-request). Issues tagged as [_Good first issue_](https://github.com/facebook/docusaurus/labels/Good%20first%20issue) are a good place to get started.
- Help us making the [docs](/docs/introduction) better. File an issue if you find anything that is confusing or can be improved. We also have [an umbrella issue for v2 docs](https://github.com/facebook/docusaurus/issues/1640) where we are planning and working on all v2 docs. You may adopt a doc piece there to work on.

This comment has been minimized.

Copy link
@endiliey

endiliey Jul 25, 2019

Collaborator

dont use hardcoded url /docs/introduction

use introduction.md

This comment has been minimized.

Copy link
@wgao19

wgao19 Jul 25, 2019

Author Collaborator

actually, decided to remove the link because the reader should already be in the doc.

@wgao19 wgao19 requested a review from endiliey Jul 25, 2019

@endiliey endiliey merged commit 162bfc4 into master Jul 25, 2019

4 checks passed

ci/circleci: lint-prettier Your tests passed on CircleCI!
Details
ci/circleci: tests Your tests passed on CircleCI!
Details
deploy/netlify Deploy preview ready!
Details
netlify/docusaurus-2/deploy-preview Deploy preview ready!
Details

@endiliey endiliey deleted the wgao19/docs-contributing branch Jul 25, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.