Resubmit #113 this fixes #155 #247
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to https://developer.mozilla.org/en-US/docs/Web/API/Blob.Blob type and endings are optional arguments. (http://dev.w3.org/2006/webapi/FileAPI/#dfn-BlobPropertyBag also says type is optional, but has no endings argument at all)
Contributor
|
Great, thanks for resubmitting! Sorry about clobbering the change before...we've got a much better process now for merging PRs internally plus we're going to start publishing commit history for each release, so hopefully this won't happen in the future. Though I suppose optional object parameters weren't really working until this v0.2.0 :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to https://developer.mozilla.org/en-US/docs/Web/API/Blob.Blob type and endings are optional arguments.
(http://dev.w3.org/2006/webapi/FileAPI/#dfn-BlobPropertyBag also says type is optional, but has no endings argument at all)