Skip to content

Conversation

@terinjokes
Copy link
Contributor

No description provided.

@facebook-github-bot
Copy link
Contributor

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@terinjokes
Copy link
Contributor Author

IMHO, the following test should cause a failure:

var WAT = Symbol('foo', 'bar');

The declaration is only for 1 (optional) parameter, but two are given.

@jeffmo
Copy link
Contributor

jeffmo commented Apr 15, 2015

Can you add a test for the double-parameter circumstance and put a // TODO: Expected error by it? I agree this should be an error...

jeffmo added a commit that referenced this pull request Apr 15, 2015
Symbol should be called statically. Fix #391
@jeffmo jeffmo merged commit e5c94d2 into facebook:master Apr 15, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants