Disable all warnings for homebrew & opam release builds#4158
Closed
gabelevi wants to merge 2 commits into
Closed
Conversation
Contributor
Author
|
Just realized that the same warning is going to break opam too...let's see if I can fix that as well |
|
@gabelevi thanks for looking into this! |
Contributor
|
@gabelevi This is the opam build PR: ocaml/opam-repository#9491 |
Contributor
Author
|
Well, it's good to know opam doesn't error, despite the warning. However, I distinctly remember it erroring on warnings before, hence #2237 |
Contributor
|
@gabelevi has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should avoid issues like Homebrew/homebrew-core#14545 where our CI is happy with the build (since we use 4.03.0) but it hits a warning in 4.04.0 when built with homebrew.
Test Plan:
Previously
make all-homebrewwould error with 4.04.0I could never get
opam install flowtypeto error, but I can at least confirm that this doesn't make it worse.