Skip to content

Disable all warnings for homebrew & opam release builds#4158

Closed
gabelevi wants to merge 2 commits into
facebook:masterfrom
gabelevi:release
Closed

Disable all warnings for homebrew & opam release builds#4158
gabelevi wants to merge 2 commits into
facebook:masterfrom
gabelevi:release

Conversation

@gabelevi

@gabelevi gabelevi commented Jun 13, 2017

Copy link
Copy Markdown
Contributor

This should avoid issues like Homebrew/homebrew-core#14545 where our CI is happy with the build (since we use 4.03.0) but it hits a warning in 4.04.0 when built with homebrew.

Test Plan:

opam switch 4.04.0
eval `opam config env`
make clean
make # Errored
make clean
FLOW_RELEASE=1 make # Worked
make all-homebrew # Worked
opam pin add flowtype .

Previously make all-homebrew would error with 4.04.0

I could never get opam install flowtype to error, but I can at least confirm that this doesn't make it worse.

@gabelevi

Copy link
Copy Markdown
Contributor Author

Just realized that the same warning is going to break opam too...let's see if I can fix that as well

@ilovezfs

Copy link
Copy Markdown

@gabelevi thanks for looking into this!

@avikchaudhuri

Copy link
Copy Markdown
Contributor

@gabelevi This is the opam build PR: ocaml/opam-repository#9491

@gabelevi gabelevi changed the title Disable all warnings for homebrew build Disable all warnings for homebrew & opam release builds Jun 13, 2017
@gabelevi

Copy link
Copy Markdown
Contributor Author

Well, it's good to know opam doesn't error, despite the warning. However, I distinctly remember it erroring on warnings before, hence #2237

@facebook-github-bot

Copy link
Copy Markdown
Contributor

@gabelevi has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants