Exclude Meta-specific code in ext/fb #9601
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. (Because this pull request was imported automatically, there will not be any future comments.) |
Contributor
|
Looks good to me, thanks. Would you mind rebasing? That would make it easier for me to merge this. (No merge conflicts, I just want to re-trigger our internal CI.) |
FBSerialize.h and related files were removed from OSS in 9b12e0b due to them being referenced in many other projects in fbcode, not just HHVM. As the HHVM functions exposing this serialization are unlikely to have been of use to non-Meta end users to begin with, exclude code referencing FBSerialize in the OSS build.
mszabo-wikia
force-pushed
the
cleanup-fbserialize
branch
from
1155c65 to
a83df97
Compare
Contributor
|
@mszabo-wikia has updated the pull request. You must reimport the pull request before landing. |
Contributor
Author
|
Done, thank you! |
Contributor
|
This pull request has been merged in 3ad314c. |
markbhasawut
added a commit
to markbhasawut/hhvm
that referenced
this pull request
Dec 18, 2025
This reverts commit 3ad314c. This will make fb-ext to be usable in OSS again.
markbhasawut
added a commit
to markbhasawut/hhvm
that referenced
this pull request
Dec 18, 2025
This reverts commit 3ad314c. This will make fb-ext to be usable in OSS again.
markbhasawut
added a commit
to markbhasawut/hhvm
that referenced
this pull request
Dec 18, 2025
This reverts commit 3ad314c. This will make fb-ext to be usable in OSS again.
markbhasawut
added a commit
to markbhasawut/hhvm
that referenced
this pull request
Dec 19, 2025
This reverts commit 3ad314c. This will make fb-ext to be usable in OSS again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FBSerialize.h and related files were removed from OSS in 9b12e0b due to them being referenced in many other projects in fbcode, not just HHVM.
As the HHVM functions exposing this serialization are unlikely to have been of use to non-Meta end users to begin with, exclude code referencing FBSerialize in the OSS build.