[lexical-playground] Bug Fix: Convert remaining icon glyphs to mask-image for forced-colors support#8781
Merged
Conversation
…mage for forced-colors support
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Contributor
Author
|
Agreed — the version with your suggestions looks visually better. Applied |
etrepum
approved these changes
Jul 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
PR #8591 converted toolbar icon glyphs from
background-imagetomask-imagefor forced-colors accessibility support. Threei.xxxselectors were missed and still rendered as solid rectangles in forced-colors mode:i.star— Review icon in the slash menui.bucket— color button in the sticky note componentAlso removes the dead
i.paletteCSS rule and its unusedpalette.svgasset (no references in any tsx/ts file).Additionally, per @levensta's suggestion, increased toolbar padding from 4px to 6px and added
scrollbar-width: thinso buttons aren't as crowded and the scrollbar is less visually intrusive.Test plan
i.xxxselectors usebackground-image(awkscan, zero hits)