[lexical-react] Bug Fix: Use the SSR-safe useLayoutEffect in Placeholder - #8906
Merged
etrepum merged 1 commit intoAug 2, 2026
Merged
Conversation
LexicalContentEditable.tsx imports useLayoutEffect straight from React and calls it in Placeholder, so rendering a ContentEditable with a placeholder on the server logs "useLayoutEffect does nothing on the server" on every pass. The package already ships shared/useLayoutEffect.ts for this, which falls back to useEffect when CAN_USE_DOM is false, and the sibling shared/useCanShowPlaceholder.ts uses it. Import it here too, and drop the react-hooks/set-state-in-effect disable that the rule no longer reports (same as useCanShowPlaceholder, which sets state in the shimmed effect without one). No behavioural change in the browser: CAN_USE_DOM is true there, so the shim is useLayoutEffect.
arcs-
requested review from
acywatson,
etrepum,
fantactuka,
ivailop7,
potatowagon and
zurfyx
as code owners
August 2, 2026 09:53
meta-cla
Bot
added
the
CLA Signed
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
etrepum
approved these changes
Aug 2, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
PlaceholderimporteduseLayoutEffectstraight from reactuseLayoutEffect does nothing on the serverThis PR uses the
shared/useLayoutEffectinstead, which removes the warning and seems to be the way this has been used in the past.I also removed
react-hooks/set-state-in-effectsince it doesn't trigger anymoreTest plan
renderToStringof aContentEditablewith aplaceholder, dev build:Before
1 warning
After
0 warnings
pnpm run lint,pnpm run test-unitclean.