[lexical-rich-text] Bug Fix: preserve heading format and style when splitting a heading - #8926
Merged
Merged
Conversation
…plitting a heading HeadingNode.insertNewAfter() copied the tag and direction onto the second half of a split heading but not the block format or style, so pressing Enter in the middle of a centered heading produced a left-aligned one. ParagraphNode.insertNewAfter() and ListItemNode.insertNewAfter() both carry those over already.
LeSingh1
requested review from
acywatson,
etrepum,
fantactuka,
ivailop7,
potatowagon and
zurfyx
as code owners
August 4, 2026 20:11
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
meta-cla
Bot
added
the
CLA Signed
etrepum
approved these changes
Aug 5, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
HeadingNode.insertNewAfter()copies the tag and direction onto the second half of a split heading but not the block format or style. Pressing Enter in the middle of a centered heading produces a left-aligned one.ParagraphNode.insertNewAfter()andListItemNode.insertNewAfter()(via$copyNode) already carry both over.This copies
getFormatType()andgetStyle()onto the new heading. Only the heading-to-heading split path is affected; the end-of-heading path still creates a plain paragraph.Test plan
Before
New unit test
HeadingNode.insertNewAfter() middle keeps format and stylefails on main:After
Passes;
Tests 20 passed (20)in that file.pnpm run test-unitgreen (227 files, 4939 passed).