MyRocks: define BSD-style endian conversion functions #1204
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
macOS does not have beXXtoh and htobeXX functions. Define them using macOS equivalents.
|
@hermanlee has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Aug 30, 2022
Summary: macOS does not have beXXtoh and htobeXX functions. Define them using macOS equivalents. Both downstreams have done the same: https://github.com/percona/percona-server/pull/4808/files#diff-083593616349ef36e9a39f1251813d7c0fe6a93883f131fe041f0d167dfe941f, MariaDB/server@b64910c#diff-083593616349ef36e9a39f1251813d7c0fe6a93883f131fe041f0d167dfe941f This patch is closer to MariaDB one instead of Percona : use general `__APPLE__` define instead of RocksDB core `OS_MACOSX`, define only used functions, and define them right after system header includes. Pull Request resolved: #1204 Reviewed By: Pushapgl Differential Revision: D38956497 Pulled By: hermanlee fbshipit-source-id: d82fad1
alanliang
pushed a commit
to alanliang/mysql-5.6
that referenced
this pull request
Mar 4, 2023
Summary: macOS does not have beXXtoh and htobeXX functions. Define them using macOS equivalents. Both downstreams have done the same: https://github.com/percona/percona-server/pull/4808/files#diff-083593616349ef36e9a39f1251813d7c0fe6a93883f131fe041f0d167dfe941f, MariaDB/server@b64910c#diff-083593616349ef36e9a39f1251813d7c0fe6a93883f131fe041f0d167dfe941f This patch is closer to MariaDB one instead of Percona : use general `__APPLE__` define instead of RocksDB core `OS_MACOSX`, define only used functions, and define them right after system header includes. Pull Request resolved: facebook#1204 GitHub Author: Laurynas Biveinis <laurynas.biveinis@gmail.com> Test Plan: Imported from GitHub, without a `Test Plan:` line. Reviewers: luqun, pgl Reviewed By: pgl Subscribers: pgl, webscalesql-eng@fb.com Differential Revision: https://phabricator.intern.facebook.com/D38956497 Tags: accept2ship
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
May 11, 2023
…ok#1204) Summary: macOS does not have beXXtoh and htobeXX functions. Define them using macOS equivalents. Both downstreams have done the same: https://github.com/percona/percona-server/pull/4808/files#diff-083593616349ef36e9a39f1251813d7c0fe6a93883f131fe041f0d167dfe941f, MariaDB/server@b64910c#diff-083593616349ef36e9a39f1251813d7c0fe6a93883f131fe041f0d167dfe941f This patch is closer to MariaDB one instead of Percona : use general `__APPLE__` define instead of RocksDB core `OS_MACOSX`, define only used functions, and define them right after system header includes. Pull Request resolved: facebook#1204 Reviewed By: Pushapgl Differential Revision: D38956497 Pulled By: hermanlee fbshipit-source-id: d82fad1
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
May 18, 2023
…ok#1204) Summary: macOS does not have beXXtoh and htobeXX functions. Define them using macOS equivalents. Both downstreams have done the same: https://github.com/percona/percona-server/pull/4808/files#diff-083593616349ef36e9a39f1251813d7c0fe6a93883f131fe041f0d167dfe941f, MariaDB/server@b64910c#diff-083593616349ef36e9a39f1251813d7c0fe6a93883f131fe041f0d167dfe941f This patch is closer to MariaDB one instead of Percona : use general `__APPLE__` define instead of RocksDB core `OS_MACOSX`, define only used functions, and define them right after system header includes. Pull Request resolved: facebook#1204 Reviewed By: Pushapgl Differential Revision: D38956497 Pulled By: hermanlee fbshipit-source-id: d82fad1
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
May 26, 2023
…ok#1204) Summary: macOS does not have beXXtoh and htobeXX functions. Define them using macOS equivalents. Both downstreams have done the same: https://github.com/percona/percona-server/pull/4808/files#diff-083593616349ef36e9a39f1251813d7c0fe6a93883f131fe041f0d167dfe941f, MariaDB/server@b64910c#diff-083593616349ef36e9a39f1251813d7c0fe6a93883f131fe041f0d167dfe941f This patch is closer to MariaDB one instead of Percona : use general `__APPLE__` define instead of RocksDB core `OS_MACOSX`, define only used functions, and define them right after system header includes. Pull Request resolved: facebook#1204 Reviewed By: Pushapgl Differential Revision: D38956497 Pulled By: hermanlee fbshipit-source-id: d82fad1
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jun 1, 2023
…ok#1204) Summary: macOS does not have beXXtoh and htobeXX functions. Define them using macOS equivalents. Both downstreams have done the same: https://github.com/percona/percona-server/pull/4808/files#diff-083593616349ef36e9a39f1251813d7c0fe6a93883f131fe041f0d167dfe941f, MariaDB/server@b64910c#diff-083593616349ef36e9a39f1251813d7c0fe6a93883f131fe041f0d167dfe941f This patch is closer to MariaDB one instead of Percona : use general `__APPLE__` define instead of RocksDB core `OS_MACOSX`, define only used functions, and define them right after system header includes. Pull Request resolved: facebook#1204 Reviewed By: Pushapgl Differential Revision: D38956497 Pulled By: hermanlee fbshipit-source-id: d82fad1
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jun 14, 2023
…ok#1204) Summary: macOS does not have beXXtoh and htobeXX functions. Define them using macOS equivalents. Both downstreams have done the same: https://github.com/percona/percona-server/pull/4808/files#diff-083593616349ef36e9a39f1251813d7c0fe6a93883f131fe041f0d167dfe941f, MariaDB/server@b64910c#diff-083593616349ef36e9a39f1251813d7c0fe6a93883f131fe041f0d167dfe941f This patch is closer to MariaDB one instead of Percona : use general `__APPLE__` define instead of RocksDB core `OS_MACOSX`, define only used functions, and define them right after system header includes. Pull Request resolved: facebook#1204 Reviewed By: Pushapgl Differential Revision: D38956497 Pulled By: hermanlee fbshipit-source-id: d82fad1
hermanlee
pushed a commit
to hermanlee/mysql-5.6
that referenced
this pull request
Oct 18, 2023
…ok#1204) Summary: macOS does not have beXXtoh and htobeXX functions. Define them using macOS equivalents. Both downstreams have done the same: https://github.com/percona/percona-server/pull/4808/files#diff-083593616349ef36e9a39f1251813d7c0fe6a93883f131fe041f0d167dfe941f, MariaDB/server@b64910c#diff-083593616349ef36e9a39f1251813d7c0fe6a93883f131fe041f0d167dfe941f This patch is closer to MariaDB one instead of Percona : use general `__APPLE__` define instead of RocksDB core `OS_MACOSX`, define only used functions, and define them right after system header includes. Pull Request resolved: facebook#1204 Reviewed By: Pushapgl Differential Revision: D38956497 Pulled By: hermanlee
inikep
pushed a commit
to inikep/percona-server
that referenced
this pull request
Apr 9, 2024
…a#1204) Summary: macOS does not have beXXtoh and htobeXX functions. Define them using macOS equivalents. Both downstreams have done the same: https://github.com/percona/percona-server/pull/4808/files#diff-083593616349ef36e9a39f1251813d7c0fe6a93883f131fe041f0d167dfe941f, MariaDB/server@b64910c#diff-083593616349ef36e9a39f1251813d7c0fe6a93883f131fe041f0d167dfe941f This patch is closer to MariaDB one instead of Percona : use general `__APPLE__` define instead of RocksDB core `OS_MACOSX`, define only used functions, and define them right after system header includes. Pull Request resolved: facebook/mysql-5.6#1204 Reviewed By: Pushapgl Differential Revision: D38956497 Pulled By: hermanlee
inikep
pushed a commit
to inikep/percona-server
that referenced
this pull request
Apr 10, 2024
…a#1204) Summary: macOS does not have beXXtoh and htobeXX functions. Define them using macOS equivalents. Both downstreams have done the same: https://github.com/percona/percona-server/pull/4808/files#diff-083593616349ef36e9a39f1251813d7c0fe6a93883f131fe041f0d167dfe941f, MariaDB/server@b64910c#diff-083593616349ef36e9a39f1251813d7c0fe6a93883f131fe041f0d167dfe941f This patch is closer to MariaDB one instead of Percona : use general `__APPLE__` define instead of RocksDB core `OS_MACOSX`, define only used functions, and define them right after system header includes. Pull Request resolved: facebook/mysql-5.6#1204 Reviewed By: Pushapgl Differential Revision: D38956497 Pulled By: hermanlee
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
May 7, 2024
…ok#1204) Summary: macOS does not have beXXtoh and htobeXX functions. Define them using macOS equivalents. Both downstreams have done the same: https://github.com/percona/percona-server/pull/4808/files#diff-083593616349ef36e9a39f1251813d7c0fe6a93883f131fe041f0d167dfe941f, MariaDB/server@b64910c#diff-083593616349ef36e9a39f1251813d7c0fe6a93883f131fe041f0d167dfe941f This patch is closer to MariaDB one instead of Percona : use general `__APPLE__` define instead of RocksDB core `OS_MACOSX`, define only used functions, and define them right after system header includes. Pull Request resolved: facebook#1204 Reviewed By: Pushapgl Differential Revision: D38956497 Pulled By: hermanlee
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Aug 2, 2024
…ok#1204) Summary: macOS does not have beXXtoh and htobeXX functions. Define them using macOS equivalents. Both downstreams have done the same: https://github.com/percona/percona-server/pull/4808/files#diff-083593616349ef36e9a39f1251813d7c0fe6a93883f131fe041f0d167dfe941f, MariaDB/server@b64910c#diff-083593616349ef36e9a39f1251813d7c0fe6a93883f131fe041f0d167dfe941f This patch is closer to MariaDB one instead of Percona : use general `__APPLE__` define instead of RocksDB core `OS_MACOSX`, define only used functions, and define them right after system header includes. Pull Request resolved: facebook#1204 Reviewed By: Pushapgl Differential Revision: D38956497 Pulled By: hermanlee
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
macOS does not have beXXtoh and htobeXX functions. Define them using macOS
equivalents.
Both downstreams have done the same: https://github.com/percona/percona-server/pull/4808/files#diff-083593616349ef36e9a39f1251813d7c0fe6a93883f131fe041f0d167dfe941f, MariaDB/server@b64910c#diff-083593616349ef36e9a39f1251813d7c0fe6a93883f131fe041f0d167dfe941f
This patch is closer to MariaDB one instead of Percona : use general
__APPLE__define instead of RocksDB coreOS_MACOSX, define only used functions, and define them right after system header includes.