Add set/get server version api #1296
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luqun
reviewed
Apr 24, 2023
luqun
reviewed
Apr 24, 2023
sunshine-Chun
force-pushed
the
fb-mysql-8.0.28-dd-api1
branch
from
ab67b50 to
7b3db1d
Compare
|
@sunshine-Chun has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
sunshine-Chun
force-pushed
the
fb-mysql-8.0.28-dd-api1
branch
from
7b3db1d to
ddc6bde
Compare
|
@sunshine-Chun has updated the pull request. You must reimport the pull request before landing. |
sunshine-Chun
force-pushed
the
fb-mysql-8.0.28-dd-api1
branch
from
ddc6bde to
4db5a98
Compare
|
@sunshine-Chun has updated the pull request. You must reimport the pull request before landing. |
Contributor
Author
|
dict_manager is a static variable declared in ha_rocksdb.cc. The get/set server version call rely on this variable. However this variable is not accessible in rdb_native_dd. we can either make it global or we can wrap it in ha_rocksdb. (The current implementation). LMK your thoughts. |
Contributor
Wrapping LGTM |
|
@sunshine-Chun has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
sunshine-Chun
force-pushed
the
fb-mysql-8.0.28-dd-api1
branch
from
4db5a98 to
8d29177
Compare
|
@sunshine-Chun has updated the pull request. You must reimport the pull request before landing. |
sunshine-Chun
force-pushed
the
fb-mysql-8.0.28-dd-api1
branch
from
8d29177 to
9d28ed7
Compare
|
@sunshine-Chun has updated the pull request. You must reimport the pull request before landing. |
|
@sunshine-Chun has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
sunshine-Chun
force-pushed
the
fb-mysql-8.0.28-dd-api1
branch
from
9d28ed7 to
823d43b
Compare
|
@sunshine-Chun has updated the pull request. You must reimport the pull request before landing. |
|
@sunshine-Chun has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags:
sunshine-Chun
force-pushed
the
fb-mysql-8.0.28-dd-api1
branch
from
823d43b to
39efd2c
Compare
|
@sunshine-Chun has updated the pull request. You must reimport the pull request before landing. |
|
@sunshine-Chun has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
facebook-github-bot
pushed a commit
that referenced
this pull request
May 4, 2023
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
May 18, 2023
Summary: This diff added support for set/get server version api in rocksdb Pull Request resolved: facebook#1296 Test Plan: Test it locally Reviewed By: luqun Differential Revision: D45332426 Pulled By: sunshine-Chun fbshipit-source-id: 3180a98
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jun 1, 2023
Summary: This diff added support for set/get server version api in rocksdb Pull Request resolved: facebook#1296 Test Plan: Test it locally Reviewed By: luqun Differential Revision: D45332426 Pulled By: sunshine-Chun fbshipit-source-id: 3180a98 ------------------------------------------------------------------------ Add rocksdb_is_supported_system_table api support for rocksdb dd (facebook#1299) Summary: We are adding support for data dictionary related rocksdb_hton handler functions. This will include the current diff and couple of following diffs. Each diff will add support for one or several rocksdb_hton handler function. This diff adds support for rocksdb_is_supported_system_table. Return false for now. More logic may need to be added once we have more prototype for dd bootstraping. Pull Request resolved: facebook#1299 Test Plan: The diff will unblock the test failure in D44598701 Imported from GitHub, without a `Test Plan:` line. Reviewed By: luqun Differential Revision: D45723276 Pulled By: sunshine-Chun fbshipit-source-id: 9edee51
luqun
pushed a commit
to luqun/mysql-5.6
that referenced
this pull request
Jun 5, 2023
Summary: This diff added support for set/get server version api in rocksdb Pull Request resolved: facebook#1296 GitHub Author: Chun Ni <chni@fb.com> Test Plan: Test it locally Reviewers: luqun, #mysql_eng Reviewed By: luqun Subscribers: webscalesql-eng@fb.com Differential Revision: https://phabricator.intern.facebook.com/D45332426 Tags: accept2ship
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jun 14, 2023
Summary: This diff added support for set/get server version api in rocksdb Pull Request resolved: facebook#1296 Test Plan: Test it locally Reviewed By: luqun Differential Revision: D45332426 Pulled By: sunshine-Chun fbshipit-source-id: 3180a98 ------------------------------------------------------------------------ Add rocksdb_is_supported_system_table api support for rocksdb dd (facebook#1299) Summary: We are adding support for data dictionary related rocksdb_hton handler functions. This will include the current diff and couple of following diffs. Each diff will add support for one or several rocksdb_hton handler function. This diff adds support for rocksdb_is_supported_system_table. Return false for now. More logic may need to be added once we have more prototype for dd bootstraping. Pull Request resolved: facebook#1299 Test Plan: The diff will unblock the test failure in D44598701 Imported from GitHub, without a `Test Plan:` line. Reviewed By: luqun Differential Revision: D45723276 Pulled By: sunshine-Chun fbshipit-source-id: 9edee51
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jun 19, 2023
Summary: This diff added support for set/get server version api in rocksdb Pull Request resolved: facebook#1296 Test Plan: Test it locally Reviewed By: luqun Differential Revision: D45332426 Pulled By: sunshine-Chun fbshipit-source-id: 3180a98 ------------------------------------------------------------------------ Add rocksdb_is_supported_system_table api support for rocksdb dd (facebook#1299) Summary: We are adding support for data dictionary related rocksdb_hton handler functions. This will include the current diff and couple of following diffs. Each diff will add support for one or several rocksdb_hton handler function. This diff adds support for rocksdb_is_supported_system_table. Return false for now. More logic may need to be added once we have more prototype for dd bootstraping. Pull Request resolved: facebook#1299 Test Plan: The diff will unblock the test failure in D44598701 Imported from GitHub, without a `Test Plan:` line. Reviewed By: luqun Differential Revision: D45723276 Pulled By: sunshine-Chun fbshipit-source-id: 9edee51
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jun 23, 2023
Summary: This diff added support for set/get server version api in rocksdb Pull Request resolved: facebook#1296 Test Plan: Test it locally Reviewed By: luqun Differential Revision: D45332426 Pulled By: sunshine-Chun fbshipit-source-id: 3180a98 ------------------------------------------------------------------------ Add rocksdb_is_supported_system_table api support for rocksdb dd (facebook#1299) Summary: We are adding support for data dictionary related rocksdb_hton handler functions. This will include the current diff and couple of following diffs. Each diff will add support for one or several rocksdb_hton handler function. This diff adds support for rocksdb_is_supported_system_table. Return false for now. More logic may need to be added once we have more prototype for dd bootstraping. Pull Request resolved: facebook#1299 Test Plan: The diff will unblock the test failure in D44598701 Imported from GitHub, without a `Test Plan:` line. Reviewed By: luqun Differential Revision: D45723276 Pulled By: sunshine-Chun fbshipit-source-id: 9edee51
hermanlee
pushed a commit
to hermanlee/mysql-5.6
that referenced
this pull request
Oct 3, 2023
Summary: This diff added support for set/get server version api in rocksdb Pull Request resolved: facebook#1296 Test Plan: Test it locally Reviewed By: luqun Differential Revision: D45332426 Pulled By: sunshine-Chun ------------------------------------------------------------------------ Add rocksdb_is_supported_system_table api support for rocksdb dd (facebook#1299) Summary: We are adding support for data dictionary related rocksdb_hton handler functions. This will include the current diff and couple of following diffs. Each diff will add support for one or several rocksdb_hton handler function. This diff adds support for rocksdb_is_supported_system_table. Return false for now. More logic may need to be added once we have more prototype for dd bootstraping. Pull Request resolved: facebook#1299 Test Plan: The diff will unblock the test failure in D44598701 Imported from GitHub, without a `Test Plan:` line. Reviewed By: luqun Differential Revision: D45723276 Pulled By: sunshine-Chun
hermanlee
pushed a commit
to hermanlee/mysql-5.6
that referenced
this pull request
Oct 18, 2023
Summary: This diff added support for set/get server version api in rocksdb Pull Request resolved: facebook#1296 Test Plan: Test it locally Reviewed By: luqun Differential Revision: D45332426 Pulled By: sunshine-Chun ------------------------------------------------------------------------ Add rocksdb_is_supported_system_table api support for rocksdb dd (facebook#1299) Summary: We are adding support for data dictionary related rocksdb_hton handler functions. This will include the current diff and couple of following diffs. Each diff will add support for one or several rocksdb_hton handler function. This diff adds support for rocksdb_is_supported_system_table. Return false for now. More logic may need to be added once we have more prototype for dd bootstraping. Pull Request resolved: facebook#1299 Test Plan: The diff will unblock the test failure in D44598701 Imported from GitHub, without a `Test Plan:` line. Reviewed By: luqun Differential Revision: D45723276 Pulled By: sunshine-Chun
inikep
pushed a commit
to inikep/percona-server
that referenced
this pull request
Dec 20, 2023
Upstream commit ID: facebook/mysql-5.6@78b9bbd PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951) Summary: This diff added support for set/get server version api in rocksdb Pull Request resolved: facebook/mysql-5.6#1296 Test Plan: Test it locally Reviewed By: luqun Differential Revision: D45332426 Pulled By: sunshine-Chun fbshipit-source-id: 3180a98e5367487a845f4abaf9a8da26752f3620
inikep
pushed a commit
to inikep/percona-server
that referenced
this pull request
Dec 20, 2023
Upstream commit ID: facebook/mysql-5.6@78b9bbd PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951) Summary: This diff added support for set/get server version api in rocksdb Pull Request resolved: facebook/mysql-5.6#1296 Test Plan: Test it locally Reviewed By: luqun Differential Revision: D45332426 Pulled By: sunshine-Chun fbshipit-source-id: 3180a98e5367487a845f4abaf9a8da26752f3620
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
May 7, 2024
Summary: This diff added support for set/get server version api in rocksdb Pull Request resolved: facebook#1296 Test Plan: Test it locally Reviewed By: luqun Differential Revision: D45332426 Pulled By: sunshine-Chun ------------------------------------------------------------------------ Add rocksdb_is_supported_system_table api support for rocksdb dd (facebook#1299) Summary: We are adding support for data dictionary related rocksdb_hton handler functions. This will include the current diff and couple of following diffs. Each diff will add support for one or several rocksdb_hton handler function. This diff adds support for rocksdb_is_supported_system_table. Return false for now. More logic may need to be added once we have more prototype for dd bootstraping. Pull Request resolved: facebook#1299 Test Plan: The diff will unblock the test failure in D44598701 Imported from GitHub, without a `Test Plan:` line. Reviewed By: luqun Differential Revision: D45723276 Pulled By: sunshine-Chun
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
May 8, 2024
Summary: This diff added support for set/get server version api in rocksdb Pull Request resolved: facebook#1296 Test Plan: Test it locally Reviewed By: luqun Differential Revision: D45332426 Pulled By: sunshine-Chun ------------------------------------------------------------------------ Add rocksdb_is_supported_system_table api support for rocksdb dd (facebook#1299) Summary: We are adding support for data dictionary related rocksdb_hton handler functions. This will include the current diff and couple of following diffs. Each diff will add support for one or several rocksdb_hton handler function. This diff adds support for rocksdb_is_supported_system_table. Return false for now. More logic may need to be added once we have more prototype for dd bootstraping. Pull Request resolved: facebook#1299 Test Plan: The diff will unblock the test failure in D44598701 Imported from GitHub, without a `Test Plan:` line. Reviewed By: luqun Differential Revision: D45723276 Pulled By: sunshine-Chun
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
May 9, 2024
Summary: This diff added support for set/get server version api in rocksdb Pull Request resolved: facebook#1296 Test Plan: Test it locally Reviewed By: luqun Differential Revision: D45332426 Pulled By: sunshine-Chun ------------------------------------------------------------------------ Add rocksdb_is_supported_system_table api support for rocksdb dd (facebook#1299) Summary: We are adding support for data dictionary related rocksdb_hton handler functions. This will include the current diff and couple of following diffs. Each diff will add support for one or several rocksdb_hton handler function. This diff adds support for rocksdb_is_supported_system_table. Return false for now. More logic may need to be added once we have more prototype for dd bootstraping. Pull Request resolved: facebook#1299 Test Plan: The diff will unblock the test failure in D44598701 Imported from GitHub, without a `Test Plan:` line. Reviewed By: luqun Differential Revision: D45723276 Pulled By: sunshine-Chun
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
May 10, 2024
Summary: This diff added support for set/get server version api in rocksdb Pull Request resolved: facebook#1296 Test Plan: Test it locally Reviewed By: luqun Differential Revision: D45332426 Pulled By: sunshine-Chun ------------------------------------------------------------------------ Add rocksdb_is_supported_system_table api support for rocksdb dd (facebook#1299) Summary: We are adding support for data dictionary related rocksdb_hton handler functions. This will include the current diff and couple of following diffs. Each diff will add support for one or several rocksdb_hton handler function. This diff adds support for rocksdb_is_supported_system_table. Return false for now. More logic may need to be added once we have more prototype for dd bootstraping. Pull Request resolved: facebook#1299 Test Plan: The diff will unblock the test failure in D44598701 Imported from GitHub, without a `Test Plan:` line. Reviewed By: luqun Differential Revision: D45723276 Pulled By: sunshine-Chun
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
May 13, 2024
Summary: This diff added support for set/get server version api in rocksdb Pull Request resolved: facebook#1296 Test Plan: Test it locally Reviewed By: luqun Differential Revision: D45332426 Pulled By: sunshine-Chun ------------------------------------------------------------------------ Add rocksdb_is_supported_system_table api support for rocksdb dd (facebook#1299) Summary: We are adding support for data dictionary related rocksdb_hton handler functions. This will include the current diff and couple of following diffs. Each diff will add support for one or several rocksdb_hton handler function. This diff adds support for rocksdb_is_supported_system_table. Return false for now. More logic may need to be added once we have more prototype for dd bootstraping. Pull Request resolved: facebook#1299 Test Plan: The diff will unblock the test failure in D44598701 Imported from GitHub, without a `Test Plan:` line. Reviewed By: luqun Differential Revision: D45723276 Pulled By: sunshine-Chun
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
May 15, 2024
Summary: This diff added support for set/get server version api in rocksdb Pull Request resolved: facebook#1296 Test Plan: Test it locally Reviewed By: luqun Differential Revision: D45332426 Pulled By: sunshine-Chun ------------------------------------------------------------------------ Add rocksdb_is_supported_system_table api support for rocksdb dd (facebook#1299) Summary: We are adding support for data dictionary related rocksdb_hton handler functions. This will include the current diff and couple of following diffs. Each diff will add support for one or several rocksdb_hton handler function. This diff adds support for rocksdb_is_supported_system_table. Return false for now. More logic may need to be added once we have more prototype for dd bootstraping. Pull Request resolved: facebook#1299 Test Plan: The diff will unblock the test failure in D44598701 Imported from GitHub, without a `Test Plan:` line. Reviewed By: luqun Differential Revision: D45723276 Pulled By: sunshine-Chun
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
May 16, 2024
Summary: This diff added support for set/get server version api in rocksdb Pull Request resolved: facebook#1296 Test Plan: Test it locally Reviewed By: luqun Differential Revision: D45332426 Pulled By: sunshine-Chun ------------------------------------------------------------------------ Add rocksdb_is_supported_system_table api support for rocksdb dd (facebook#1299) Summary: We are adding support for data dictionary related rocksdb_hton handler functions. This will include the current diff and couple of following diffs. Each diff will add support for one or several rocksdb_hton handler function. This diff adds support for rocksdb_is_supported_system_table. Return false for now. More logic may need to be added once we have more prototype for dd bootstraping. Pull Request resolved: facebook#1299 Test Plan: The diff will unblock the test failure in D44598701 Imported from GitHub, without a `Test Plan:` line. Reviewed By: luqun Differential Revision: D45723276 Pulled By: sunshine-Chun
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
May 17, 2024
Summary: This diff added support for set/get server version api in rocksdb Pull Request resolved: facebook#1296 Test Plan: Test it locally Reviewed By: luqun Differential Revision: D45332426 Pulled By: sunshine-Chun ------------------------------------------------------------------------ Add rocksdb_is_supported_system_table api support for rocksdb dd (facebook#1299) Summary: We are adding support for data dictionary related rocksdb_hton handler functions. This will include the current diff and couple of following diffs. Each diff will add support for one or several rocksdb_hton handler function. This diff adds support for rocksdb_is_supported_system_table. Return false for now. More logic may need to be added once we have more prototype for dd bootstraping. Pull Request resolved: facebook#1299 Test Plan: The diff will unblock the test failure in D44598701 Imported from GitHub, without a `Test Plan:` line. Reviewed By: luqun Differential Revision: D45723276 Pulled By: sunshine-Chun
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
May 17, 2024
Summary: This diff added support for set/get server version api in rocksdb Pull Request resolved: facebook#1296 Test Plan: Test it locally Reviewed By: luqun Differential Revision: D45332426 Pulled By: sunshine-Chun ------------------------------------------------------------------------ Add rocksdb_is_supported_system_table api support for rocksdb dd (facebook#1299) Summary: We are adding support for data dictionary related rocksdb_hton handler functions. This will include the current diff and couple of following diffs. Each diff will add support for one or several rocksdb_hton handler function. This diff adds support for rocksdb_is_supported_system_table. Return false for now. More logic may need to be added once we have more prototype for dd bootstraping. Pull Request resolved: facebook#1299 Test Plan: The diff will unblock the test failure in D44598701 Imported from GitHub, without a `Test Plan:` line. Reviewed By: luqun Differential Revision: D45723276 Pulled By: sunshine-Chun
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
May 21, 2024
Summary: This diff added support for set/get server version api in rocksdb Pull Request resolved: facebook#1296 Test Plan: Test it locally Reviewed By: luqun Differential Revision: D45332426 Pulled By: sunshine-Chun ------------------------------------------------------------------------ Add rocksdb_is_supported_system_table api support for rocksdb dd (facebook#1299) Summary: We are adding support for data dictionary related rocksdb_hton handler functions. This will include the current diff and couple of following diffs. Each diff will add support for one or several rocksdb_hton handler function. This diff adds support for rocksdb_is_supported_system_table. Return false for now. More logic may need to be added once we have more prototype for dd bootstraping. Pull Request resolved: facebook#1299 Test Plan: The diff will unblock the test failure in D44598701 Imported from GitHub, without a `Test Plan:` line. Reviewed By: luqun Differential Revision: D45723276 Pulled By: sunshine-Chun
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
May 21, 2024
Summary: This diff added support for set/get server version api in rocksdb Pull Request resolved: facebook#1296 Test Plan: Test it locally Reviewed By: luqun Differential Revision: D45332426 Pulled By: sunshine-Chun ------------------------------------------------------------------------ Add rocksdb_is_supported_system_table api support for rocksdb dd (facebook#1299) Summary: We are adding support for data dictionary related rocksdb_hton handler functions. This will include the current diff and couple of following diffs. Each diff will add support for one or several rocksdb_hton handler function. This diff adds support for rocksdb_is_supported_system_table. Return false for now. More logic may need to be added once we have more prototype for dd bootstraping. Pull Request resolved: facebook#1299 Test Plan: The diff will unblock the test failure in D44598701 Imported from GitHub, without a `Test Plan:` line. Reviewed By: luqun Differential Revision: D45723276 Pulled By: sunshine-Chun
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
May 30, 2024
Summary: This diff added support for set/get server version api in rocksdb Pull Request resolved: facebook#1296 Test Plan: Test it locally Reviewed By: luqun Differential Revision: D45332426 Pulled By: sunshine-Chun ------------------------------------------------------------------------ Add rocksdb_is_supported_system_table api support for rocksdb dd (facebook#1299) Summary: We are adding support for data dictionary related rocksdb_hton handler functions. This will include the current diff and couple of following diffs. Each diff will add support for one or several rocksdb_hton handler function. This diff adds support for rocksdb_is_supported_system_table. Return false for now. More logic may need to be added once we have more prototype for dd bootstraping. Pull Request resolved: facebook#1299 Test Plan: The diff will unblock the test failure in D44598701 Imported from GitHub, without a `Test Plan:` line. Reviewed By: luqun Differential Revision: D45723276 Pulled By: sunshine-Chun
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jul 16, 2024
Summary: This diff added support for set/get server version api in rocksdb Pull Request resolved: facebook#1296 Test Plan: Test it locally Reviewed By: luqun Differential Revision: D45332426 Pulled By: sunshine-Chun ------------------------------------------------------------------------ Add rocksdb_is_supported_system_table api support for rocksdb dd (facebook#1299) Summary: We are adding support for data dictionary related rocksdb_hton handler functions. This will include the current diff and couple of following diffs. Each diff will add support for one or several rocksdb_hton handler function. This diff adds support for rocksdb_is_supported_system_table. Return false for now. More logic may need to be added once we have more prototype for dd bootstraping. Pull Request resolved: facebook#1299 Test Plan: The diff will unblock the test failure in D44598701 Imported from GitHub, without a `Test Plan:` line. Reviewed By: luqun Differential Revision: D45723276 Pulled By: sunshine-Chun
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jul 16, 2024
Summary: This diff added support for set/get server version api in rocksdb Pull Request resolved: facebook#1296 Test Plan: Test it locally Reviewed By: luqun Differential Revision: D45332426 Pulled By: sunshine-Chun ------------------------------------------------------------------------ Add rocksdb_is_supported_system_table api support for rocksdb dd (facebook#1299) Summary: We are adding support for data dictionary related rocksdb_hton handler functions. This will include the current diff and couple of following diffs. Each diff will add support for one or several rocksdb_hton handler function. This diff adds support for rocksdb_is_supported_system_table. Return false for now. More logic may need to be added once we have more prototype for dd bootstraping. Pull Request resolved: facebook#1299 Test Plan: The diff will unblock the test failure in D44598701 Imported from GitHub, without a `Test Plan:` line. Reviewed By: luqun Differential Revision: D45723276 Pulled By: sunshine-Chun
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jul 17, 2024
Summary: This diff added support for set/get server version api in rocksdb Pull Request resolved: facebook#1296 Test Plan: Test it locally Reviewed By: luqun Differential Revision: D45332426 Pulled By: sunshine-Chun ------------------------------------------------------------------------ Add rocksdb_is_supported_system_table api support for rocksdb dd (facebook#1299) Summary: We are adding support for data dictionary related rocksdb_hton handler functions. This will include the current diff and couple of following diffs. Each diff will add support for one or several rocksdb_hton handler function. This diff adds support for rocksdb_is_supported_system_table. Return false for now. More logic may need to be added once we have more prototype for dd bootstraping. Pull Request resolved: facebook#1299 Test Plan: The diff will unblock the test failure in D44598701 Imported from GitHub, without a `Test Plan:` line. Reviewed By: luqun Differential Revision: D45723276 Pulled By: sunshine-Chun
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jul 19, 2024
Summary: This diff added support for set/get server version api in rocksdb Pull Request resolved: facebook#1296 Test Plan: Test it locally Reviewed By: luqun Differential Revision: D45332426 Pulled By: sunshine-Chun ------------------------------------------------------------------------ Add rocksdb_is_supported_system_table api support for rocksdb dd (facebook#1299) Summary: We are adding support for data dictionary related rocksdb_hton handler functions. This will include the current diff and couple of following diffs. Each diff will add support for one or several rocksdb_hton handler function. This diff adds support for rocksdb_is_supported_system_table. Return false for now. More logic may need to be added once we have more prototype for dd bootstraping. Pull Request resolved: facebook#1299 Test Plan: The diff will unblock the test failure in D44598701 Imported from GitHub, without a `Test Plan:` line. Reviewed By: luqun Differential Revision: D45723276 Pulled By: sunshine-Chun
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jul 19, 2024
Summary: This diff added support for set/get server version api in rocksdb Pull Request resolved: facebook#1296 Test Plan: Test it locally Reviewed By: luqun Differential Revision: D45332426 Pulled By: sunshine-Chun ------------------------------------------------------------------------ Add rocksdb_is_supported_system_table api support for rocksdb dd (facebook#1299) Summary: We are adding support for data dictionary related rocksdb_hton handler functions. This will include the current diff and couple of following diffs. Each diff will add support for one or several rocksdb_hton handler function. This diff adds support for rocksdb_is_supported_system_table. Return false for now. More logic may need to be added once we have more prototype for dd bootstraping. Pull Request resolved: facebook#1299 Test Plan: The diff will unblock the test failure in D44598701 Imported from GitHub, without a `Test Plan:` line. Reviewed By: luqun Differential Revision: D45723276 Pulled By: sunshine-Chun
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jul 30, 2024
Summary: This diff added support for set/get server version api in rocksdb Pull Request resolved: facebook#1296 Test Plan: Test it locally Reviewed By: luqun Differential Revision: D45332426 Pulled By: sunshine-Chun ------------------------------------------------------------------------ Add rocksdb_is_supported_system_table api support for rocksdb dd (facebook#1299) Summary: We are adding support for data dictionary related rocksdb_hton handler functions. This will include the current diff and couple of following diffs. Each diff will add support for one or several rocksdb_hton handler function. This diff adds support for rocksdb_is_supported_system_table. Return false for now. More logic may need to be added once we have more prototype for dd bootstraping. Pull Request resolved: facebook#1299 Test Plan: The diff will unblock the test failure in D44598701 Imported from GitHub, without a `Test Plan:` line. Reviewed By: luqun Differential Revision: D45723276 Pulled By: sunshine-Chun
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jul 31, 2024
Summary: This diff added support for set/get server version api in rocksdb Pull Request resolved: facebook#1296 Test Plan: Test it locally Reviewed By: luqun Differential Revision: D45332426 Pulled By: sunshine-Chun ------------------------------------------------------------------------ Add rocksdb_is_supported_system_table api support for rocksdb dd (facebook#1299) Summary: We are adding support for data dictionary related rocksdb_hton handler functions. This will include the current diff and couple of following diffs. Each diff will add support for one or several rocksdb_hton handler function. This diff adds support for rocksdb_is_supported_system_table. Return false for now. More logic may need to be added once we have more prototype for dd bootstraping. Pull Request resolved: facebook#1299 Test Plan: The diff will unblock the test failure in D44598701 Imported from GitHub, without a `Test Plan:` line. Reviewed By: luqun Differential Revision: D45723276 Pulled By: sunshine-Chun
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Aug 2, 2024
Summary: This diff added support for set/get server version api in rocksdb Pull Request resolved: facebook#1296 Test Plan: Test it locally Reviewed By: luqun Differential Revision: D45332426 Pulled By: sunshine-Chun ------------------------------------------------------------------------ Add rocksdb_is_supported_system_table api support for rocksdb dd (facebook#1299) Summary: We are adding support for data dictionary related rocksdb_hton handler functions. This will include the current diff and couple of following diffs. Each diff will add support for one or several rocksdb_hton handler function. This diff adds support for rocksdb_is_supported_system_table. Return false for now. More logic may need to be added once we have more prototype for dd bootstraping. Pull Request resolved: facebook#1299 Test Plan: The diff will unblock the test failure in D44598701 Imported from GitHub, without a `Test Plan:` line. Reviewed By: luqun Differential Revision: D45723276 Pulled By: sunshine-Chun
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Aug 6, 2024
Summary: This diff added support for set/get server version api in rocksdb Pull Request resolved: facebook#1296 Test Plan: Test it locally Reviewed By: luqun Differential Revision: D45332426 Pulled By: sunshine-Chun ------------------------------------------------------------------------ Add rocksdb_is_supported_system_table api support for rocksdb dd (facebook#1299) Summary: We are adding support for data dictionary related rocksdb_hton handler functions. This will include the current diff and couple of following diffs. Each diff will add support for one or several rocksdb_hton handler function. This diff adds support for rocksdb_is_supported_system_table. Return false for now. More logic may need to be added once we have more prototype for dd bootstraping. Pull Request resolved: facebook#1299 Test Plan: The diff will unblock the test failure in D44598701 Imported from GitHub, without a `Test Plan:` line. Reviewed By: luqun Differential Revision: D45723276 Pulled By: sunshine-Chun
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: This diff added support for set/get server version api in rocksdb
Test Plan: Test it locally
Reviewers:
Subscribers:
Tasks:
Tags: