Add dict_register_dd_table_id api support for rocksdb dd #1298
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunshine-Chun
force-pushed
the
fb-mysql-8.0.28-dd-api3
branch
from
f8c2ba5 to
b023746
Compare
sunshine-Chun
force-pushed
the
fb-mysql-8.0.28-dd-api3
branch
from
b023746 to
7812951
Compare
Contributor
laurynas-biveinis
left a comment
laurynas-biveinis
left a comment
There was a problem hiding this comment.
The other current DD PRs would also use rdb_native_dd, probably it will be easier to get this one merged and rebase the rest
sunshine-Chun
force-pushed
the
fb-mysql-8.0.28-dd-api3
branch
2 times, most recently
from
49e6df9 to
f2ce636
Compare
|
@sunshine-Chun has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
sunshine-Chun
force-pushed
the
fb-mysql-8.0.28-dd-api3
branch
from
f2ce636 to
2806d86
Compare
|
@sunshine-Chun has updated the pull request. You must reimport the pull request before landing. |
luqun
reviewed
Apr 27, 2023
sunshine-Chun
force-pushed
the
fb-mysql-8.0.28-dd-api3
branch
from
2806d86 to
6c73902
Compare
|
@sunshine-Chun has updated the pull request. You must reimport the pull request before landing. |
|
@sunshine-Chun has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
luqun
reviewed
Apr 27, 2023
sunshine-Chun
force-pushed
the
fb-mysql-8.0.28-dd-api3
branch
from
6c73902 to
c28bef8
Compare
|
@sunshine-Chun has updated the pull request. You must reimport the pull request before landing. |
|
@sunshine-Chun has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
sunshine-Chun
force-pushed
the
fb-mysql-8.0.28-dd-api3
branch
from
c28bef8 to
f227947
Compare
|
@sunshine-Chun has updated the pull request. You must reimport the pull request before landing. |
sunshine-Chun
force-pushed
the
fb-mysql-8.0.28-dd-api3
branch
from
f227947 to
e59df50
Compare
|
@sunshine-Chun has updated the pull request. You must reimport the pull request before landing. |
sunshine-Chun
force-pushed
the
fb-mysql-8.0.28-dd-api3
branch
from
e59df50 to
627e360
Compare
|
@sunshine-Chun has updated the pull request. You must reimport the pull request before landing. |
sunshine-Chun
force-pushed
the
fb-mysql-8.0.28-dd-api3
branch
from
627e360 to
144ab37
Compare
|
@sunshine-Chun has updated the pull request. You must reimport the pull request before landing. |
|
@sunshine-Chun has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
sunshine-Chun
force-pushed
the
fb-mysql-8.0.28-dd-api3
branch
from
144ab37 to
41e7a1c
Compare
|
@sunshine-Chun has updated the pull request. You must reimport the pull request before landing. |
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jun 1, 2023
Summary: We are adding support for data dictionary related rocksdb_hton functions. This will include the current diff and couple of following diffs. Each diff will add support for one or several rocksdb_hton function. This current adds support for rocksdb_hton->dict_register_dd_table_id. It contains several part 1. Add a rdb_native_dd file. The file is dedicated to rocksdb data dictionary related function and objects. 2. Add dd table check in rename_table/delete_table/truncate_table. These table operations are not allowed for dd tables. Fail the operation if it's operated on dd tables. 3. Maintain a dd table id set. Pull Request resolved: facebook#1298 Reviewed By: luqun Differential Revision: D45332365 Pulled By: sunshine-Chun fbshipit-source-id: 95aebf8
luqun
pushed a commit
to luqun/mysql-5.6
that referenced
this pull request
Jun 5, 2023
Summary: We are adding support for data dictionary related rocksdb_hton functions. This will include the current diff and couple of following diffs. Each diff will add support for one or several rocksdb_hton function. This current adds support for rocksdb_hton->dict_register_dd_table_id. It contains several part 1. Add a rdb_native_dd file. The file is dedicated to rocksdb data dictionary related function and objects. 2. Add dd table check in rename_table/delete_table/truncate_table. These table operations are not allowed for dd tables. Fail the operation if it's operated on dd tables. 3. Maintain a dd table id set. Pull Request resolved: facebook#1298 GitHub Author: Chun Ni <chni@fb.com> Test Plan: Imported from GitHub, without a `Test Plan:` line. Reviewers: luqun, #mysql_eng Reviewed By: luqun Subscribers: webscalesql-eng@fb.com Differential Revision: https://phabricator.intern.facebook.com/D45332365 Tags: accept2ship
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jun 14, 2023
Summary: We are adding support for data dictionary related rocksdb_hton functions. This will include the current diff and couple of following diffs. Each diff will add support for one or several rocksdb_hton function. This current adds support for rocksdb_hton->dict_register_dd_table_id. It contains several part 1. Add a rdb_native_dd file. The file is dedicated to rocksdb data dictionary related function and objects. 2. Add dd table check in rename_table/delete_table/truncate_table. These table operations are not allowed for dd tables. Fail the operation if it's operated on dd tables. 3. Maintain a dd table id set. Pull Request resolved: facebook#1298 Reviewed By: luqun Differential Revision: D45332365 Pulled By: sunshine-Chun fbshipit-source-id: 95aebf8
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jun 19, 2023
Summary: We are adding support for data dictionary related rocksdb_hton functions. This will include the current diff and couple of following diffs. Each diff will add support for one or several rocksdb_hton function. This current adds support for rocksdb_hton->dict_register_dd_table_id. It contains several part 1. Add a rdb_native_dd file. The file is dedicated to rocksdb data dictionary related function and objects. 2. Add dd table check in rename_table/delete_table/truncate_table. These table operations are not allowed for dd tables. Fail the operation if it's operated on dd tables. 3. Maintain a dd table id set. Pull Request resolved: facebook#1298 Reviewed By: luqun Differential Revision: D45332365 Pulled By: sunshine-Chun fbshipit-source-id: 95aebf8
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jun 23, 2023
Summary: We are adding support for data dictionary related rocksdb_hton functions. This will include the current diff and couple of following diffs. Each diff will add support for one or several rocksdb_hton function. This current adds support for rocksdb_hton->dict_register_dd_table_id. It contains several part 1. Add a rdb_native_dd file. The file is dedicated to rocksdb data dictionary related function and objects. 2. Add dd table check in rename_table/delete_table/truncate_table. These table operations are not allowed for dd tables. Fail the operation if it's operated on dd tables. 3. Maintain a dd table id set. Pull Request resolved: facebook#1298 Reviewed By: luqun Differential Revision: D45332365 Pulled By: sunshine-Chun fbshipit-source-id: 95aebf8
hermanlee
pushed a commit
to hermanlee/mysql-5.6
that referenced
this pull request
Oct 3, 2023
Summary: We are adding support for data dictionary related rocksdb_hton functions. This will include the current diff and couple of following diffs. Each diff will add support for one or several rocksdb_hton function. This current adds support for rocksdb_hton->dict_register_dd_table_id. It contains several part 1. Add a rdb_native_dd file. The file is dedicated to rocksdb data dictionary related function and objects. 2. Add dd table check in rename_table/delete_table/truncate_table. These table operations are not allowed for dd tables. Fail the operation if it's operated on dd tables. 3. Maintain a dd table id set. Pull Request resolved: facebook#1298 Reviewed By: luqun Differential Revision: D45332365 Pulled By: sunshine-Chun
hermanlee
pushed a commit
to hermanlee/mysql-5.6
that referenced
this pull request
Oct 18, 2023
Summary: We are adding support for data dictionary related rocksdb_hton functions. This will include the current diff and couple of following diffs. Each diff will add support for one or several rocksdb_hton function. This current adds support for rocksdb_hton->dict_register_dd_table_id. It contains several part 1. Add a rdb_native_dd file. The file is dedicated to rocksdb data dictionary related function and objects. 2. Add dd table check in rename_table/delete_table/truncate_table. These table operations are not allowed for dd tables. Fail the operation if it's operated on dd tables. 3. Maintain a dd table id set. Pull Request resolved: facebook#1298 Reviewed By: luqun Differential Revision: D45332365 Pulled By: sunshine-Chun
inikep
pushed a commit
to inikep/percona-server
that referenced
this pull request
Dec 20, 2023
Upstream commit ID: facebook/mysql-5.6@1a0f581 PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951) Summary: We are adding support for data dictionary related rocksdb_hton functions. This will include the current diff and couple of following diffs. Each diff will add support for one or several rocksdb_hton function. This current adds support for rocksdb_hton->dict_register_dd_table_id. It contains several part 1. Add a rdb_native_dd file. The file is dedicated to rocksdb data dictionary related function and objects. 2. Add dd table check in rename_table/delete_table/truncate_table. These table operations are not allowed for dd tables. Fail the operation if it's operated on dd tables. 3. Maintain a dd table id set. Pull Request resolved: facebook/mysql-5.6#1298 Reviewed By: luqun Differential Revision: D45332365 Pulled By: sunshine-Chun fbshipit-source-id: 95aebf8d6a4de03f37bb15438fadfe19670108ba
inikep
pushed a commit
to inikep/percona-server
that referenced
this pull request
Dec 20, 2023
Upstream commit ID: facebook/mysql-5.6@1a0f581 PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951) Summary: We are adding support for data dictionary related rocksdb_hton functions. This will include the current diff and couple of following diffs. Each diff will add support for one or several rocksdb_hton function. This current adds support for rocksdb_hton->dict_register_dd_table_id. It contains several part 1. Add a rdb_native_dd file. The file is dedicated to rocksdb data dictionary related function and objects. 2. Add dd table check in rename_table/delete_table/truncate_table. These table operations are not allowed for dd tables. Fail the operation if it's operated on dd tables. 3. Maintain a dd table id set. Pull Request resolved: facebook/mysql-5.6#1298 Reviewed By: luqun Differential Revision: D45332365 Pulled By: sunshine-Chun fbshipit-source-id: 95aebf8d6a4de03f37bb15438fadfe19670108ba
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
May 7, 2024
Summary: We are adding support for data dictionary related rocksdb_hton functions. This will include the current diff and couple of following diffs. Each diff will add support for one or several rocksdb_hton function. This current adds support for rocksdb_hton->dict_register_dd_table_id. It contains several part 1. Add a rdb_native_dd file. The file is dedicated to rocksdb data dictionary related function and objects. 2. Add dd table check in rename_table/delete_table/truncate_table. These table operations are not allowed for dd tables. Fail the operation if it's operated on dd tables. 3. Maintain a dd table id set. Pull Request resolved: facebook#1298 Reviewed By: luqun Differential Revision: D45332365 Pulled By: sunshine-Chun
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
May 8, 2024
Summary: We are adding support for data dictionary related rocksdb_hton functions. This will include the current diff and couple of following diffs. Each diff will add support for one or several rocksdb_hton function. This current adds support for rocksdb_hton->dict_register_dd_table_id. It contains several part 1. Add a rdb_native_dd file. The file is dedicated to rocksdb data dictionary related function and objects. 2. Add dd table check in rename_table/delete_table/truncate_table. These table operations are not allowed for dd tables. Fail the operation if it's operated on dd tables. 3. Maintain a dd table id set. Pull Request resolved: facebook#1298 Reviewed By: luqun Differential Revision: D45332365 Pulled By: sunshine-Chun
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
May 9, 2024
Summary: We are adding support for data dictionary related rocksdb_hton functions. This will include the current diff and couple of following diffs. Each diff will add support for one or several rocksdb_hton function. This current adds support for rocksdb_hton->dict_register_dd_table_id. It contains several part 1. Add a rdb_native_dd file. The file is dedicated to rocksdb data dictionary related function and objects. 2. Add dd table check in rename_table/delete_table/truncate_table. These table operations are not allowed for dd tables. Fail the operation if it's operated on dd tables. 3. Maintain a dd table id set. Pull Request resolved: facebook#1298 Reviewed By: luqun Differential Revision: D45332365 Pulled By: sunshine-Chun
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
May 10, 2024
Summary: We are adding support for data dictionary related rocksdb_hton functions. This will include the current diff and couple of following diffs. Each diff will add support for one or several rocksdb_hton function. This current adds support for rocksdb_hton->dict_register_dd_table_id. It contains several part 1. Add a rdb_native_dd file. The file is dedicated to rocksdb data dictionary related function and objects. 2. Add dd table check in rename_table/delete_table/truncate_table. These table operations are not allowed for dd tables. Fail the operation if it's operated on dd tables. 3. Maintain a dd table id set. Pull Request resolved: facebook#1298 Reviewed By: luqun Differential Revision: D45332365 Pulled By: sunshine-Chun
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
May 13, 2024
Summary: We are adding support for data dictionary related rocksdb_hton functions. This will include the current diff and couple of following diffs. Each diff will add support for one or several rocksdb_hton function. This current adds support for rocksdb_hton->dict_register_dd_table_id. It contains several part 1. Add a rdb_native_dd file. The file is dedicated to rocksdb data dictionary related function and objects. 2. Add dd table check in rename_table/delete_table/truncate_table. These table operations are not allowed for dd tables. Fail the operation if it's operated on dd tables. 3. Maintain a dd table id set. Pull Request resolved: facebook#1298 Reviewed By: luqun Differential Revision: D45332365 Pulled By: sunshine-Chun ----------------------------------------------------------------------------------------------- Make myrocks::native_dd::is_dd_table_id private (facebook#1421) Summary: At the same time mark the method [[nodiscard]]. Pull Request resolved: facebook#1421 Differential Revision: D52770129 fbshipit-source-id: 20b72e8
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
May 15, 2024
Summary: We are adding support for data dictionary related rocksdb_hton functions. This will include the current diff and couple of following diffs. Each diff will add support for one or several rocksdb_hton function. This current adds support for rocksdb_hton->dict_register_dd_table_id. It contains several part 1. Add a rdb_native_dd file. The file is dedicated to rocksdb data dictionary related function and objects. 2. Add dd table check in rename_table/delete_table/truncate_table. These table operations are not allowed for dd tables. Fail the operation if it's operated on dd tables. 3. Maintain a dd table id set. Pull Request resolved: facebook#1298 Reviewed By: luqun Differential Revision: D45332365 Pulled By: sunshine-Chun ----------------------------------------------------------------------------------------------- Make myrocks::native_dd::is_dd_table_id private (facebook#1421) Summary: At the same time mark the method [[nodiscard]]. Pull Request resolved: facebook#1421 Differential Revision: D52770129 fbshipit-source-id: 20b72e8
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
May 16, 2024
Summary: We are adding support for data dictionary related rocksdb_hton functions. This will include the current diff and couple of following diffs. Each diff will add support for one or several rocksdb_hton function. This current adds support for rocksdb_hton->dict_register_dd_table_id. It contains several part 1. Add a rdb_native_dd file. The file is dedicated to rocksdb data dictionary related function and objects. 2. Add dd table check in rename_table/delete_table/truncate_table. These table operations are not allowed for dd tables. Fail the operation if it's operated on dd tables. 3. Maintain a dd table id set. Pull Request resolved: facebook#1298 Reviewed By: luqun Differential Revision: D45332365 Pulled By: sunshine-Chun ----------------------------------------------------------------------------------------------- Make myrocks::native_dd::is_dd_table_id private (facebook#1421) Summary: At the same time mark the method [[nodiscard]]. Pull Request resolved: facebook#1421 Differential Revision: D52770129 fbshipit-source-id: 20b72e8
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
May 17, 2024
Summary: We are adding support for data dictionary related rocksdb_hton functions. This will include the current diff and couple of following diffs. Each diff will add support for one or several rocksdb_hton function. This current adds support for rocksdb_hton->dict_register_dd_table_id. It contains several part 1. Add a rdb_native_dd file. The file is dedicated to rocksdb data dictionary related function and objects. 2. Add dd table check in rename_table/delete_table/truncate_table. These table operations are not allowed for dd tables. Fail the operation if it's operated on dd tables. 3. Maintain a dd table id set. Pull Request resolved: facebook#1298 Reviewed By: luqun Differential Revision: D45332365 Pulled By: sunshine-Chun ----------------------------------------------------------------------------------------------- Make myrocks::native_dd::is_dd_table_id private (facebook#1421) Summary: At the same time mark the method [[nodiscard]]. Pull Request resolved: facebook#1421 Differential Revision: D52770129 fbshipit-source-id: 20b72e8
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
May 17, 2024
Summary: We are adding support for data dictionary related rocksdb_hton functions. This will include the current diff and couple of following diffs. Each diff will add support for one or several rocksdb_hton function. This current adds support for rocksdb_hton->dict_register_dd_table_id. It contains several part 1. Add a rdb_native_dd file. The file is dedicated to rocksdb data dictionary related function and objects. 2. Add dd table check in rename_table/delete_table/truncate_table. These table operations are not allowed for dd tables. Fail the operation if it's operated on dd tables. 3. Maintain a dd table id set. Pull Request resolved: facebook#1298 Reviewed By: luqun Differential Revision: D45332365 Pulled By: sunshine-Chun ----------------------------------------------------------------------------------------------- Make myrocks::native_dd::is_dd_table_id private (facebook#1421) Summary: At the same time mark the method [[nodiscard]]. Pull Request resolved: facebook#1421 Differential Revision: D52770129 fbshipit-source-id: 20b72e8
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
May 21, 2024
Summary: We are adding support for data dictionary related rocksdb_hton functions. This will include the current diff and couple of following diffs. Each diff will add support for one or several rocksdb_hton function. This current adds support for rocksdb_hton->dict_register_dd_table_id. It contains several part 1. Add a rdb_native_dd file. The file is dedicated to rocksdb data dictionary related function and objects. 2. Add dd table check in rename_table/delete_table/truncate_table. These table operations are not allowed for dd tables. Fail the operation if it's operated on dd tables. 3. Maintain a dd table id set. Pull Request resolved: facebook#1298 Reviewed By: luqun Differential Revision: D45332365 Pulled By: sunshine-Chun ----------------------------------------------------------------------------------------------- Make myrocks::native_dd::is_dd_table_id private (facebook#1421) Summary: At the same time mark the method [[nodiscard]]. Pull Request resolved: facebook#1421 Differential Revision: D52770129 fbshipit-source-id: 20b72e8
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
May 21, 2024
Summary: We are adding support for data dictionary related rocksdb_hton functions. This will include the current diff and couple of following diffs. Each diff will add support for one or several rocksdb_hton function. This current adds support for rocksdb_hton->dict_register_dd_table_id. It contains several part 1. Add a rdb_native_dd file. The file is dedicated to rocksdb data dictionary related function and objects. 2. Add dd table check in rename_table/delete_table/truncate_table. These table operations are not allowed for dd tables. Fail the operation if it's operated on dd tables. 3. Maintain a dd table id set. Pull Request resolved: facebook#1298 Reviewed By: luqun Differential Revision: D45332365 Pulled By: sunshine-Chun ----------------------------------------------------------------------------------------------- Make myrocks::native_dd::is_dd_table_id private (facebook#1421) Summary: At the same time mark the method [[nodiscard]]. Pull Request resolved: facebook#1421 Differential Revision: D52770129 fbshipit-source-id: 20b72e8
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
May 30, 2024
Summary: We are adding support for data dictionary related rocksdb_hton functions. This will include the current diff and couple of following diffs. Each diff will add support for one or several rocksdb_hton function. This current adds support for rocksdb_hton->dict_register_dd_table_id. It contains several part 1. Add a rdb_native_dd file. The file is dedicated to rocksdb data dictionary related function and objects. 2. Add dd table check in rename_table/delete_table/truncate_table. These table operations are not allowed for dd tables. Fail the operation if it's operated on dd tables. 3. Maintain a dd table id set. Pull Request resolved: facebook#1298 Reviewed By: luqun Differential Revision: D45332365 Pulled By: sunshine-Chun ----------------------------------------------------------------------------------------------- Make myrocks::native_dd::is_dd_table_id private (facebook#1421) Summary: At the same time mark the method [[nodiscard]]. Pull Request resolved: facebook#1421 Differential Revision: D52770129 fbshipit-source-id: 20b72e8
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jul 16, 2024
Summary: We are adding support for data dictionary related rocksdb_hton functions. This will include the current diff and couple of following diffs. Each diff will add support for one or several rocksdb_hton function. This current adds support for rocksdb_hton->dict_register_dd_table_id. It contains several part 1. Add a rdb_native_dd file. The file is dedicated to rocksdb data dictionary related function and objects. 2. Add dd table check in rename_table/delete_table/truncate_table. These table operations are not allowed for dd tables. Fail the operation if it's operated on dd tables. 3. Maintain a dd table id set. Pull Request resolved: facebook#1298 Reviewed By: luqun Differential Revision: D45332365 Pulled By: sunshine-Chun ----------------------------------------------------------------------------------------------- Make myrocks::native_dd::is_dd_table_id private (facebook#1421) Summary: At the same time mark the method [[nodiscard]]. Pull Request resolved: facebook#1421 Differential Revision: D52770129 fbshipit-source-id: 20b72e8
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jul 16, 2024
Summary: We are adding support for data dictionary related rocksdb_hton functions. This will include the current diff and couple of following diffs. Each diff will add support for one or several rocksdb_hton function. This current adds support for rocksdb_hton->dict_register_dd_table_id. It contains several part 1. Add a rdb_native_dd file. The file is dedicated to rocksdb data dictionary related function and objects. 2. Add dd table check in rename_table/delete_table/truncate_table. These table operations are not allowed for dd tables. Fail the operation if it's operated on dd tables. 3. Maintain a dd table id set. Pull Request resolved: facebook#1298 Reviewed By: luqun Differential Revision: D45332365 Pulled By: sunshine-Chun ----------------------------------------------------------------------------------------------- Make myrocks::native_dd::is_dd_table_id private (facebook#1421) Summary: At the same time mark the method [[nodiscard]]. Pull Request resolved: facebook#1421 Differential Revision: D52770129 fbshipit-source-id: 20b72e8
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jul 17, 2024
Summary: We are adding support for data dictionary related rocksdb_hton functions. This will include the current diff and couple of following diffs. Each diff will add support for one or several rocksdb_hton function. This current adds support for rocksdb_hton->dict_register_dd_table_id. It contains several part 1. Add a rdb_native_dd file. The file is dedicated to rocksdb data dictionary related function and objects. 2. Add dd table check in rename_table/delete_table/truncate_table. These table operations are not allowed for dd tables. Fail the operation if it's operated on dd tables. 3. Maintain a dd table id set. Pull Request resolved: facebook#1298 Reviewed By: luqun Differential Revision: D45332365 Pulled By: sunshine-Chun ----------------------------------------------------------------------------------------------- Make myrocks::native_dd::is_dd_table_id private (facebook#1421) Summary: At the same time mark the method [[nodiscard]]. Pull Request resolved: facebook#1421 Differential Revision: D52770129 fbshipit-source-id: 20b72e8
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jul 19, 2024
Summary: We are adding support for data dictionary related rocksdb_hton functions. This will include the current diff and couple of following diffs. Each diff will add support for one or several rocksdb_hton function. This current adds support for rocksdb_hton->dict_register_dd_table_id. It contains several part 1. Add a rdb_native_dd file. The file is dedicated to rocksdb data dictionary related function and objects. 2. Add dd table check in rename_table/delete_table/truncate_table. These table operations are not allowed for dd tables. Fail the operation if it's operated on dd tables. 3. Maintain a dd table id set. Pull Request resolved: facebook#1298 Reviewed By: luqun Differential Revision: D45332365 Pulled By: sunshine-Chun ----------------------------------------------------------------------------------------------- Make myrocks::native_dd::is_dd_table_id private (facebook#1421) Summary: At the same time mark the method [[nodiscard]]. Pull Request resolved: facebook#1421 Differential Revision: D52770129 fbshipit-source-id: 20b72e8
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jul 19, 2024
Summary: We are adding support for data dictionary related rocksdb_hton functions. This will include the current diff and couple of following diffs. Each diff will add support for one or several rocksdb_hton function. This current adds support for rocksdb_hton->dict_register_dd_table_id. It contains several part 1. Add a rdb_native_dd file. The file is dedicated to rocksdb data dictionary related function and objects. 2. Add dd table check in rename_table/delete_table/truncate_table. These table operations are not allowed for dd tables. Fail the operation if it's operated on dd tables. 3. Maintain a dd table id set. Pull Request resolved: facebook#1298 Reviewed By: luqun Differential Revision: D45332365 Pulled By: sunshine-Chun ----------------------------------------------------------------------------------------------- Make myrocks::native_dd::is_dd_table_id private (facebook#1421) Summary: At the same time mark the method [[nodiscard]]. Pull Request resolved: facebook#1421 Differential Revision: D52770129 fbshipit-source-id: 20b72e8
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jul 30, 2024
Summary: We are adding support for data dictionary related rocksdb_hton functions. This will include the current diff and couple of following diffs. Each diff will add support for one or several rocksdb_hton function. This current adds support for rocksdb_hton->dict_register_dd_table_id. It contains several part 1. Add a rdb_native_dd file. The file is dedicated to rocksdb data dictionary related function and objects. 2. Add dd table check in rename_table/delete_table/truncate_table. These table operations are not allowed for dd tables. Fail the operation if it's operated on dd tables. 3. Maintain a dd table id set. Pull Request resolved: facebook#1298 Reviewed By: luqun Differential Revision: D45332365 Pulled By: sunshine-Chun ----------------------------------------------------------------------------------------------- Make myrocks::native_dd::is_dd_table_id private (facebook#1421) Summary: At the same time mark the method [[nodiscard]]. Pull Request resolved: facebook#1421 Differential Revision: D52770129 fbshipit-source-id: 20b72e8
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jul 31, 2024
Summary: We are adding support for data dictionary related rocksdb_hton functions. This will include the current diff and couple of following diffs. Each diff will add support for one or several rocksdb_hton function. This current adds support for rocksdb_hton->dict_register_dd_table_id. It contains several part 1. Add a rdb_native_dd file. The file is dedicated to rocksdb data dictionary related function and objects. 2. Add dd table check in rename_table/delete_table/truncate_table. These table operations are not allowed for dd tables. Fail the operation if it's operated on dd tables. 3. Maintain a dd table id set. Pull Request resolved: facebook#1298 Reviewed By: luqun Differential Revision: D45332365 Pulled By: sunshine-Chun ----------------------------------------------------------------------------------------------- Make myrocks::native_dd::is_dd_table_id private (facebook#1421) Summary: At the same time mark the method [[nodiscard]]. Pull Request resolved: facebook#1421 Differential Revision: D52770129 fbshipit-source-id: 20b72e8
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Aug 2, 2024
Summary: We are adding support for data dictionary related rocksdb_hton functions. This will include the current diff and couple of following diffs. Each diff will add support for one or several rocksdb_hton function. This current adds support for rocksdb_hton->dict_register_dd_table_id. It contains several part 1. Add a rdb_native_dd file. The file is dedicated to rocksdb data dictionary related function and objects. 2. Add dd table check in rename_table/delete_table/truncate_table. These table operations are not allowed for dd tables. Fail the operation if it's operated on dd tables. 3. Maintain a dd table id set. Pull Request resolved: facebook#1298 Reviewed By: luqun Differential Revision: D45332365 Pulled By: sunshine-Chun ----------------------------------------------------------------------------------------------- Make myrocks::native_dd::is_dd_table_id private (facebook#1421) Summary: At the same time mark the method [[nodiscard]]. Pull Request resolved: facebook#1421 Differential Revision: D52770129 fbshipit-source-id: 20b72e8
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Aug 6, 2024
Summary: We are adding support for data dictionary related rocksdb_hton functions. This will include the current diff and couple of following diffs. Each diff will add support for one or several rocksdb_hton function. This current adds support for rocksdb_hton->dict_register_dd_table_id. It contains several part 1. Add a rdb_native_dd file. The file is dedicated to rocksdb data dictionary related function and objects. 2. Add dd table check in rename_table/delete_table/truncate_table. These table operations are not allowed for dd tables. Fail the operation if it's operated on dd tables. 3. Maintain a dd table id set. Pull Request resolved: facebook#1298 Reviewed By: luqun Differential Revision: D45332365 Pulled By: sunshine-Chun ----------------------------------------------------------------------------------------------- Make myrocks::native_dd::is_dd_table_id private (facebook#1421) Summary: At the same time mark the method [[nodiscard]]. Pull Request resolved: facebook#1421 Differential Revision: D52770129 fbshipit-source-id: 20b72e8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: as title
Test Plan:
Reviewers:
Subscribers:
Tasks:
Tags: