Make myrocks::native_dd::is_dd_table_id private #1421
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At the same time mark the method [[nodiscard]].
|
@luqun has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
This pull request has been merged in f3f3d2c. |
sunxiayi
pushed a commit
to sunxiayi/mysql-5.6
that referenced
this pull request
Apr 30, 2024
Summary: At the same time mark the method [[nodiscard]]. Pull Request resolved: facebook#1421 GitHub Author: Laurynas Biveinis <laurynas.biveinis@gmail.com> Test Plan: Imported from GitHub, without a `Test Plan:` line. Reviewers: saumitr, chni, #mysql_eng Reviewed By: saumitr Differential Revision: https://phabricator.intern.facebook.com/D52770129
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
May 13, 2024
Summary: We are adding support for data dictionary related rocksdb_hton functions. This will include the current diff and couple of following diffs. Each diff will add support for one or several rocksdb_hton function. This current adds support for rocksdb_hton->dict_register_dd_table_id. It contains several part 1. Add a rdb_native_dd file. The file is dedicated to rocksdb data dictionary related function and objects. 2. Add dd table check in rename_table/delete_table/truncate_table. These table operations are not allowed for dd tables. Fail the operation if it's operated on dd tables. 3. Maintain a dd table id set. Pull Request resolved: facebook#1298 Reviewed By: luqun Differential Revision: D45332365 Pulled By: sunshine-Chun ----------------------------------------------------------------------------------------------- Make myrocks::native_dd::is_dd_table_id private (facebook#1421) Summary: At the same time mark the method [[nodiscard]]. Pull Request resolved: facebook#1421 Differential Revision: D52770129 fbshipit-source-id: 20b72e8
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
May 15, 2024
Summary: We are adding support for data dictionary related rocksdb_hton functions. This will include the current diff and couple of following diffs. Each diff will add support for one or several rocksdb_hton function. This current adds support for rocksdb_hton->dict_register_dd_table_id. It contains several part 1. Add a rdb_native_dd file. The file is dedicated to rocksdb data dictionary related function and objects. 2. Add dd table check in rename_table/delete_table/truncate_table. These table operations are not allowed for dd tables. Fail the operation if it's operated on dd tables. 3. Maintain a dd table id set. Pull Request resolved: facebook#1298 Reviewed By: luqun Differential Revision: D45332365 Pulled By: sunshine-Chun ----------------------------------------------------------------------------------------------- Make myrocks::native_dd::is_dd_table_id private (facebook#1421) Summary: At the same time mark the method [[nodiscard]]. Pull Request resolved: facebook#1421 Differential Revision: D52770129 fbshipit-source-id: 20b72e8
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
May 16, 2024
Summary: We are adding support for data dictionary related rocksdb_hton functions. This will include the current diff and couple of following diffs. Each diff will add support for one or several rocksdb_hton function. This current adds support for rocksdb_hton->dict_register_dd_table_id. It contains several part 1. Add a rdb_native_dd file. The file is dedicated to rocksdb data dictionary related function and objects. 2. Add dd table check in rename_table/delete_table/truncate_table. These table operations are not allowed for dd tables. Fail the operation if it's operated on dd tables. 3. Maintain a dd table id set. Pull Request resolved: facebook#1298 Reviewed By: luqun Differential Revision: D45332365 Pulled By: sunshine-Chun ----------------------------------------------------------------------------------------------- Make myrocks::native_dd::is_dd_table_id private (facebook#1421) Summary: At the same time mark the method [[nodiscard]]. Pull Request resolved: facebook#1421 Differential Revision: D52770129 fbshipit-source-id: 20b72e8
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
May 17, 2024
Summary: We are adding support for data dictionary related rocksdb_hton functions. This will include the current diff and couple of following diffs. Each diff will add support for one or several rocksdb_hton function. This current adds support for rocksdb_hton->dict_register_dd_table_id. It contains several part 1. Add a rdb_native_dd file. The file is dedicated to rocksdb data dictionary related function and objects. 2. Add dd table check in rename_table/delete_table/truncate_table. These table operations are not allowed for dd tables. Fail the operation if it's operated on dd tables. 3. Maintain a dd table id set. Pull Request resolved: facebook#1298 Reviewed By: luqun Differential Revision: D45332365 Pulled By: sunshine-Chun ----------------------------------------------------------------------------------------------- Make myrocks::native_dd::is_dd_table_id private (facebook#1421) Summary: At the same time mark the method [[nodiscard]]. Pull Request resolved: facebook#1421 Differential Revision: D52770129 fbshipit-source-id: 20b72e8
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
May 17, 2024
Summary: We are adding support for data dictionary related rocksdb_hton functions. This will include the current diff and couple of following diffs. Each diff will add support for one or several rocksdb_hton function. This current adds support for rocksdb_hton->dict_register_dd_table_id. It contains several part 1. Add a rdb_native_dd file. The file is dedicated to rocksdb data dictionary related function and objects. 2. Add dd table check in rename_table/delete_table/truncate_table. These table operations are not allowed for dd tables. Fail the operation if it's operated on dd tables. 3. Maintain a dd table id set. Pull Request resolved: facebook#1298 Reviewed By: luqun Differential Revision: D45332365 Pulled By: sunshine-Chun ----------------------------------------------------------------------------------------------- Make myrocks::native_dd::is_dd_table_id private (facebook#1421) Summary: At the same time mark the method [[nodiscard]]. Pull Request resolved: facebook#1421 Differential Revision: D52770129 fbshipit-source-id: 20b72e8
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
May 21, 2024
Summary: We are adding support for data dictionary related rocksdb_hton functions. This will include the current diff and couple of following diffs. Each diff will add support for one or several rocksdb_hton function. This current adds support for rocksdb_hton->dict_register_dd_table_id. It contains several part 1. Add a rdb_native_dd file. The file is dedicated to rocksdb data dictionary related function and objects. 2. Add dd table check in rename_table/delete_table/truncate_table. These table operations are not allowed for dd tables. Fail the operation if it's operated on dd tables. 3. Maintain a dd table id set. Pull Request resolved: facebook#1298 Reviewed By: luqun Differential Revision: D45332365 Pulled By: sunshine-Chun ----------------------------------------------------------------------------------------------- Make myrocks::native_dd::is_dd_table_id private (facebook#1421) Summary: At the same time mark the method [[nodiscard]]. Pull Request resolved: facebook#1421 Differential Revision: D52770129 fbshipit-source-id: 20b72e8
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
May 21, 2024
Summary: We are adding support for data dictionary related rocksdb_hton functions. This will include the current diff and couple of following diffs. Each diff will add support for one or several rocksdb_hton function. This current adds support for rocksdb_hton->dict_register_dd_table_id. It contains several part 1. Add a rdb_native_dd file. The file is dedicated to rocksdb data dictionary related function and objects. 2. Add dd table check in rename_table/delete_table/truncate_table. These table operations are not allowed for dd tables. Fail the operation if it's operated on dd tables. 3. Maintain a dd table id set. Pull Request resolved: facebook#1298 Reviewed By: luqun Differential Revision: D45332365 Pulled By: sunshine-Chun ----------------------------------------------------------------------------------------------- Make myrocks::native_dd::is_dd_table_id private (facebook#1421) Summary: At the same time mark the method [[nodiscard]]. Pull Request resolved: facebook#1421 Differential Revision: D52770129 fbshipit-source-id: 20b72e8
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
May 30, 2024
Summary: We are adding support for data dictionary related rocksdb_hton functions. This will include the current diff and couple of following diffs. Each diff will add support for one or several rocksdb_hton function. This current adds support for rocksdb_hton->dict_register_dd_table_id. It contains several part 1. Add a rdb_native_dd file. The file is dedicated to rocksdb data dictionary related function and objects. 2. Add dd table check in rename_table/delete_table/truncate_table. These table operations are not allowed for dd tables. Fail the operation if it's operated on dd tables. 3. Maintain a dd table id set. Pull Request resolved: facebook#1298 Reviewed By: luqun Differential Revision: D45332365 Pulled By: sunshine-Chun ----------------------------------------------------------------------------------------------- Make myrocks::native_dd::is_dd_table_id private (facebook#1421) Summary: At the same time mark the method [[nodiscard]]. Pull Request resolved: facebook#1421 Differential Revision: D52770129 fbshipit-source-id: 20b72e8
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jul 16, 2024
Summary: We are adding support for data dictionary related rocksdb_hton functions. This will include the current diff and couple of following diffs. Each diff will add support for one or several rocksdb_hton function. This current adds support for rocksdb_hton->dict_register_dd_table_id. It contains several part 1. Add a rdb_native_dd file. The file is dedicated to rocksdb data dictionary related function and objects. 2. Add dd table check in rename_table/delete_table/truncate_table. These table operations are not allowed for dd tables. Fail the operation if it's operated on dd tables. 3. Maintain a dd table id set. Pull Request resolved: facebook#1298 Reviewed By: luqun Differential Revision: D45332365 Pulled By: sunshine-Chun ----------------------------------------------------------------------------------------------- Make myrocks::native_dd::is_dd_table_id private (facebook#1421) Summary: At the same time mark the method [[nodiscard]]. Pull Request resolved: facebook#1421 Differential Revision: D52770129 fbshipit-source-id: 20b72e8
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jul 16, 2024
Summary: We are adding support for data dictionary related rocksdb_hton functions. This will include the current diff and couple of following diffs. Each diff will add support for one or several rocksdb_hton function. This current adds support for rocksdb_hton->dict_register_dd_table_id. It contains several part 1. Add a rdb_native_dd file. The file is dedicated to rocksdb data dictionary related function and objects. 2. Add dd table check in rename_table/delete_table/truncate_table. These table operations are not allowed for dd tables. Fail the operation if it's operated on dd tables. 3. Maintain a dd table id set. Pull Request resolved: facebook#1298 Reviewed By: luqun Differential Revision: D45332365 Pulled By: sunshine-Chun ----------------------------------------------------------------------------------------------- Make myrocks::native_dd::is_dd_table_id private (facebook#1421) Summary: At the same time mark the method [[nodiscard]]. Pull Request resolved: facebook#1421 Differential Revision: D52770129 fbshipit-source-id: 20b72e8
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jul 17, 2024
Summary: We are adding support for data dictionary related rocksdb_hton functions. This will include the current diff and couple of following diffs. Each diff will add support for one or several rocksdb_hton function. This current adds support for rocksdb_hton->dict_register_dd_table_id. It contains several part 1. Add a rdb_native_dd file. The file is dedicated to rocksdb data dictionary related function and objects. 2. Add dd table check in rename_table/delete_table/truncate_table. These table operations are not allowed for dd tables. Fail the operation if it's operated on dd tables. 3. Maintain a dd table id set. Pull Request resolved: facebook#1298 Reviewed By: luqun Differential Revision: D45332365 Pulled By: sunshine-Chun ----------------------------------------------------------------------------------------------- Make myrocks::native_dd::is_dd_table_id private (facebook#1421) Summary: At the same time mark the method [[nodiscard]]. Pull Request resolved: facebook#1421 Differential Revision: D52770129 fbshipit-source-id: 20b72e8
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jul 19, 2024
Summary: We are adding support for data dictionary related rocksdb_hton functions. This will include the current diff and couple of following diffs. Each diff will add support for one or several rocksdb_hton function. This current adds support for rocksdb_hton->dict_register_dd_table_id. It contains several part 1. Add a rdb_native_dd file. The file is dedicated to rocksdb data dictionary related function and objects. 2. Add dd table check in rename_table/delete_table/truncate_table. These table operations are not allowed for dd tables. Fail the operation if it's operated on dd tables. 3. Maintain a dd table id set. Pull Request resolved: facebook#1298 Reviewed By: luqun Differential Revision: D45332365 Pulled By: sunshine-Chun ----------------------------------------------------------------------------------------------- Make myrocks::native_dd::is_dd_table_id private (facebook#1421) Summary: At the same time mark the method [[nodiscard]]. Pull Request resolved: facebook#1421 Differential Revision: D52770129 fbshipit-source-id: 20b72e8
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jul 19, 2024
Summary: We are adding support for data dictionary related rocksdb_hton functions. This will include the current diff and couple of following diffs. Each diff will add support for one or several rocksdb_hton function. This current adds support for rocksdb_hton->dict_register_dd_table_id. It contains several part 1. Add a rdb_native_dd file. The file is dedicated to rocksdb data dictionary related function and objects. 2. Add dd table check in rename_table/delete_table/truncate_table. These table operations are not allowed for dd tables. Fail the operation if it's operated on dd tables. 3. Maintain a dd table id set. Pull Request resolved: facebook#1298 Reviewed By: luqun Differential Revision: D45332365 Pulled By: sunshine-Chun ----------------------------------------------------------------------------------------------- Make myrocks::native_dd::is_dd_table_id private (facebook#1421) Summary: At the same time mark the method [[nodiscard]]. Pull Request resolved: facebook#1421 Differential Revision: D52770129 fbshipit-source-id: 20b72e8
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jul 30, 2024
Summary: We are adding support for data dictionary related rocksdb_hton functions. This will include the current diff and couple of following diffs. Each diff will add support for one or several rocksdb_hton function. This current adds support for rocksdb_hton->dict_register_dd_table_id. It contains several part 1. Add a rdb_native_dd file. The file is dedicated to rocksdb data dictionary related function and objects. 2. Add dd table check in rename_table/delete_table/truncate_table. These table operations are not allowed for dd tables. Fail the operation if it's operated on dd tables. 3. Maintain a dd table id set. Pull Request resolved: facebook#1298 Reviewed By: luqun Differential Revision: D45332365 Pulled By: sunshine-Chun ----------------------------------------------------------------------------------------------- Make myrocks::native_dd::is_dd_table_id private (facebook#1421) Summary: At the same time mark the method [[nodiscard]]. Pull Request resolved: facebook#1421 Differential Revision: D52770129 fbshipit-source-id: 20b72e8
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jul 31, 2024
Summary: We are adding support for data dictionary related rocksdb_hton functions. This will include the current diff and couple of following diffs. Each diff will add support for one or several rocksdb_hton function. This current adds support for rocksdb_hton->dict_register_dd_table_id. It contains several part 1. Add a rdb_native_dd file. The file is dedicated to rocksdb data dictionary related function and objects. 2. Add dd table check in rename_table/delete_table/truncate_table. These table operations are not allowed for dd tables. Fail the operation if it's operated on dd tables. 3. Maintain a dd table id set. Pull Request resolved: facebook#1298 Reviewed By: luqun Differential Revision: D45332365 Pulled By: sunshine-Chun ----------------------------------------------------------------------------------------------- Make myrocks::native_dd::is_dd_table_id private (facebook#1421) Summary: At the same time mark the method [[nodiscard]]. Pull Request resolved: facebook#1421 Differential Revision: D52770129 fbshipit-source-id: 20b72e8
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Aug 2, 2024
Summary: We are adding support for data dictionary related rocksdb_hton functions. This will include the current diff and couple of following diffs. Each diff will add support for one or several rocksdb_hton function. This current adds support for rocksdb_hton->dict_register_dd_table_id. It contains several part 1. Add a rdb_native_dd file. The file is dedicated to rocksdb data dictionary related function and objects. 2. Add dd table check in rename_table/delete_table/truncate_table. These table operations are not allowed for dd tables. Fail the operation if it's operated on dd tables. 3. Maintain a dd table id set. Pull Request resolved: facebook#1298 Reviewed By: luqun Differential Revision: D45332365 Pulled By: sunshine-Chun ----------------------------------------------------------------------------------------------- Make myrocks::native_dd::is_dd_table_id private (facebook#1421) Summary: At the same time mark the method [[nodiscard]]. Pull Request resolved: facebook#1421 Differential Revision: D52770129 fbshipit-source-id: 20b72e8
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Aug 6, 2024
Summary: We are adding support for data dictionary related rocksdb_hton functions. This will include the current diff and couple of following diffs. Each diff will add support for one or several rocksdb_hton function. This current adds support for rocksdb_hton->dict_register_dd_table_id. It contains several part 1. Add a rdb_native_dd file. The file is dedicated to rocksdb data dictionary related function and objects. 2. Add dd table check in rename_table/delete_table/truncate_table. These table operations are not allowed for dd tables. Fail the operation if it's operated on dd tables. 3. Maintain a dd table id set. Pull Request resolved: facebook#1298 Reviewed By: luqun Differential Revision: D45332365 Pulled By: sunshine-Chun ----------------------------------------------------------------------------------------------- Make myrocks::native_dd::is_dd_table_id private (facebook#1421) Summary: At the same time mark the method [[nodiscard]]. Pull Request resolved: facebook#1421 Differential Revision: D52770129 fbshipit-source-id: 20b72e8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the same time mark the method [[nodiscard]].