Skip to content

[MyRocks] Set exclusive_manual_compaction = false on manual compactions #682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[MyRocks] Set exclusive_manual_compaction = false on manual compactions #682

wants to merge 1 commit into from

Conversation

@yoshinorim
Copy link
Contributor

@yoshinorim yoshinorim commented Aug 15, 2017

Summary: Combining exclusive manual compaction and
non-exclusive manual compaction may hit rocksdb assertion errors.
This diff makes all MyRocks internal manual compactions non exclusive.

Test Plan: mtr

@facebook-github-bot
Copy link

facebook-github-bot commented Aug 15, 2017

@yoshinorim has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link

facebook-github-bot commented Aug 15, 2017

@yoshinorim updated the pull request - view changes - changes since last import

@facebook-github-bot
Copy link

facebook-github-bot commented Aug 15, 2017

@yoshinorim has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@yoshinorim
[MyRocks] Set exclusive_manual_compaction = false on manual compactions
d852987 
Summary: Combining exclusive manual compaction and
non-exclusive manual compaction may hit rocksdb assertion errors.
This diff makes all MyRocks internal manual compactions non exclusive.

Test Plan: mtr
@facebook-github-bot
Copy link

facebook-github-bot commented Aug 15, 2017

@yoshinorim updated the pull request - view changes - changes since last import

@facebook-github-bot
Copy link

facebook-github-bot commented Aug 15, 2017

@yoshinorim has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link

facebook-github-bot commented Aug 15, 2017

@yoshinorim has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

spetrunia added a commit to MariaDB/server that referenced this pull request Aug 16, 2017
@spetrunia
MDEV-13513: rocksdb.drop_table fails in buidbot with assertion failure
b3a4bc4 
Apply this patch from upstream:

commit 2c8deddfb67f1cd41ea3d1ac95aa1aa9327e3406
Author: Yoshinori Matsunobu <yoshinorim@users.noreply.github.com>
Date:   Tue Aug 15 16:21:58 2017 -0700

    Set exclusive_manual_compaction = false on manual compactions

    Summary:
    Combining exclusive manual compaction and
    non-exclusive manual compaction may hit rocksdb assertion errors.
    This diff makes all MyRocks internal manual compactions non exclusive.
    Closes facebook/mysql-5.6#682

    Differential Revision: D5633619

    Pulled By: yoshinorim

    fbshipit-source-id: a90786d
samcmuldroch pushed a commit to samcmuldroch/mysql-5.6 that referenced this pull request Sep 6, 2017
@yoshinorim
[mysql-5.6][PR] [MyRocks] Set exclusive_manual_compaction = false on …
a90786d 
…manual compactions

Summary:
Combining exclusive manual compaction and
non-exclusive manual compaction may hit rocksdb assertion errors.
This diff makes all MyRocks internal manual compactions non exclusive.
Closes facebook#682
GitHub Author: Yoshinori Matsunobu <yoshinorim@users.noreply.github.com>

Github PR Sync: {sync, type="child", parent="github", parentrepo="facebook/mysql-5.6", parentprnum="682", parentprfbid="1642878375742901"}

Test Plan: mtr

Reviewers: svcscm

Reviewed By: svcscm

Subscribers: svcscm, webscalesql-eng@fb.com, trunkagent

Differential Revision: https://phabricator.intern.facebook.com/D5633619
george-lorch pushed a commit to george-lorch/percona-server that referenced this pull request Oct 4, 2017
@yoshinorim
Set exclusive_manual_compaction = false on manual compactions
e532834 
Upstream commit ID : fb-mysql-5.6.35/2c8deddfb67f1cd41ea3d1ac95aa1aa9327e3406

Summary:
Combining exclusive manual compaction and
non-exclusive manual compaction may hit rocksdb assertion errors.
This diff makes all MyRocks internal manual compactions non exclusive.
Closes facebook/mysql-5.6#682

Differential Revision: D5633619

Pulled By: yoshinorim

fbshipit-source-id: a90786d
facebook-github-bot pushed a commit that referenced this pull request Dec 23, 2019
@yoshinorim @facebook-github-bot
Set exclusive_manual_compaction = false on manual compactions (#682)
77c4678 
Summary:
Combining exclusive manual compaction and
non-exclusive manual compaction may hit rocksdb assertion errors.
This diff makes all MyRocks internal manual compactions non exclusive.
Closes #682

Test Plan: mtr

Differential Revision: D5633619

Pulled By: yoshinorim

fbshipit-source-id: 11cc2fd
inikep pushed a commit to inikep/mysql-5.6 that referenced this pull request Aug 12, 2020
@yoshinorim @inikep
Set exclusive_manual_compaction = false on manual compactions (facebo…
51e80f3 
…ok#682)

Summary:
Combining exclusive manual compaction and
non-exclusive manual compaction may hit rocksdb assertion errors.
This diff makes all MyRocks internal manual compactions non exclusive.
Closes facebook#682

Test Plan: mtr

Differential Revision: D5633619

Pulled By: yoshinorim

fbshipit-source-id: 11cc2fd
inikep pushed a commit to inikep/mysql-5.6 that referenced this pull request Sep 9, 2020
@yoshinorim @inikep
Set exclusive_manual_compaction = false on manual compactions (facebo…
96cb05e 
…ok#682)

Summary:
Combining exclusive manual compaction and
non-exclusive manual compaction may hit rocksdb assertion errors.
This diff makes all MyRocks internal manual compactions non exclusive.
Closes facebook#682

Test Plan: mtr

Differential Revision: D5633619

Pulled By: yoshinorim

fbshipit-source-id: 11cc2fd
inikep pushed a commit to inikep/mysql-5.6 that referenced this pull request Sep 16, 2020
@yoshinorim @inikep
Set exclusive_manual_compaction = false on manual compactions (facebo…
5357296 
…ok#682)

Summary:
Combining exclusive manual compaction and
non-exclusive manual compaction may hit rocksdb assertion errors.
This diff makes all MyRocks internal manual compactions non exclusive.
Closes facebook#682

Test Plan: mtr

Differential Revision: D5633619

Pulled By: yoshinorim

fbshipit-source-id: 11cc2fd
inikep pushed a commit to inikep/mysql-5.6 that referenced this pull request Oct 5, 2020
@yoshinorim @inikep
Set exclusive_manual_compaction = false on manual compactions (facebo…
39189a1 
…ok#682)

Summary:
Combining exclusive manual compaction and
non-exclusive manual compaction may hit rocksdb assertion errors.
This diff makes all MyRocks internal manual compactions non exclusive.
Closes facebook#682

Test Plan: mtr

Differential Revision: D5633619

Pulled By: yoshinorim

fbshipit-source-id: 11cc2fd
inikep pushed a commit to inikep/mysql-5.6 that referenced this pull request Nov 11, 2020
@yoshinorim @inikep
Set exclusive_manual_compaction = false on manual compactions (facebo…
dd02f99 
…ok#682)

Summary:
Combining exclusive manual compaction and
non-exclusive manual compaction may hit rocksdb assertion errors.
This diff makes all MyRocks internal manual compactions non exclusive.
Closes facebook#682

Test Plan: mtr

Differential Revision: D5633619

Pulled By: yoshinorim

fbshipit-source-id: 11cc2fd
facebook-github-bot pushed a commit that referenced this pull request Mar 8, 2021
@yoshinorim @facebook-github-bot
Set exclusive_manual_compaction = false on manual compactions (#682) (#…
45122b5 
…682)

Summary:
Combining exclusive manual compaction and
non-exclusive manual compaction may hit rocksdb assertion errors.
This diff makes all MyRocks internal manual compactions non exclusive.
Closes #682

Differential Revision: D5633619 (2c8dedd)

Pulled By: yoshinorim

fbshipit-source-id: efb6565e53f
inikep pushed a commit to inikep/mysql-5.6 that referenced this pull request Aug 16, 2021
@yoshinorim @inikep
Set exclusive_manual_compaction = false on manual compactions (facebo…
8c4ae32 
…ok#682) (facebook#682)

Summary:
Combining exclusive manual compaction and
non-exclusive manual compaction may hit rocksdb assertion errors.
This diff makes all MyRocks internal manual compactions non exclusive.
Closes facebook#682

Differential Revision: D5633619 (facebook@2c8dedd)

Pulled By: yoshinorim

fbshipit-source-id: efb6565e53f
inikep pushed a commit to inikep/mysql-5.6 that referenced this pull request Aug 17, 2021
@yoshinorim @inikep
Set exclusive_manual_compaction = false on manual compactions (facebo…
f9231ce 
…ok#682) (facebook#682)

Summary:
Combining exclusive manual compaction and
non-exclusive manual compaction may hit rocksdb assertion errors.
This diff makes all MyRocks internal manual compactions non exclusive.
Closes facebook#682

Differential Revision: D5633619 (facebook@2c8dedd)

Pulled By: yoshinorim

fbshipit-source-id: efb6565e53f
inikep pushed a commit to inikep/mysql-5.6 that referenced this pull request Aug 30, 2021
@yoshinorim @inikep
Set exclusive_manual_compaction = false on manual compactions (facebo…
3603879 
…ok#682) (facebook#682)

Summary:
Combining exclusive manual compaction and
non-exclusive manual compaction may hit rocksdb assertion errors.
This diff makes all MyRocks internal manual compactions non exclusive.
Closes facebook#682

Differential Revision: D5633619 (facebook@2c8dedd)

Pulled By: yoshinorim

fbshipit-source-id: efb6565e53f
inikep pushed a commit to inikep/mysql-5.6 that referenced this pull request Aug 30, 2021
@yoshinorim @inikep
Set exclusive_manual_compaction = false on manual compactions (facebo…
efd9dd2 
…ok#682) (facebook#682)

Summary:
Combining exclusive manual compaction and
non-exclusive manual compaction may hit rocksdb assertion errors.
This diff makes all MyRocks internal manual compactions non exclusive.
Closes facebook#682

Differential Revision: D5633619 (facebook@2c8dedd)

Pulled By: yoshinorim

fbshipit-source-id: efb6565e53f
inikep pushed a commit to inikep/mysql-5.6 that referenced this pull request Aug 31, 2021
@yoshinorim @inikep
Set exclusive_manual_compaction = false on manual compactions (facebo…
b430179 
…ok#682) (facebook#682)

Summary:
Combining exclusive manual compaction and
non-exclusive manual compaction may hit rocksdb assertion errors.
This diff makes all MyRocks internal manual compactions non exclusive.
Closes facebook#682

Differential Revision: D5633619 (facebook@2c8dedd)

Pulled By: yoshinorim

fbshipit-source-id: efb6565e53f
inikep pushed a commit to inikep/mysql-5.6 that referenced this pull request Sep 1, 2021
@yoshinorim @inikep
Set exclusive_manual_compaction = false on manual compactions (facebo…
63bb00f 
…ok#682) (facebook#682)

Summary:
Combining exclusive manual compaction and
non-exclusive manual compaction may hit rocksdb assertion errors.
This diff makes all MyRocks internal manual compactions non exclusive.
Closes facebook#682

Differential Revision: D5633619 (facebook@2c8dedd)

Pulled By: yoshinorim

fbshipit-source-id: efb6565e53f
inikep pushed a commit to inikep/mysql-5.6 that referenced this pull request Sep 2, 2021
@yoshinorim @inikep
Set exclusive_manual_compaction = false on manual compactions (facebo…
f616815 
…ok#682) (facebook#682)

Summary:
Combining exclusive manual compaction and
non-exclusive manual compaction may hit rocksdb assertion errors.
This diff makes all MyRocks internal manual compactions non exclusive.
Closes facebook#682

Differential Revision: D5633619 (facebook@2c8dedd)

Pulled By: yoshinorim

fbshipit-source-id: efb6565e53f
hermanlee pushed a commit that referenced this pull request Jan 10, 2022
@yoshinorim
Set exclusive_manual_compaction = false on manual compactions (#682) (#…
36f76ce 
…682)

Summary:
Combining exclusive manual compaction and
non-exclusive manual compaction may hit rocksdb assertion errors.
This diff makes all MyRocks internal manual compactions non exclusive.
Closes #682

Differential Revision: D5633619

Pulled By: yoshinorim
inikep pushed a commit to inikep/mysql-5.6 that referenced this pull request Jan 17, 2022
@yoshinorim @inikep
Set exclusive_manual_compaction = false on manual compactions (facebo…
26b2985 
…ok#682) (facebook#682)

Summary:
Combining exclusive manual compaction and
non-exclusive manual compaction may hit rocksdb assertion errors.
This diff makes all MyRocks internal manual compactions non exclusive.
Closes facebook#682

Differential Revision: D5633619

Pulled By: yoshinorim
ldonoso pushed a commit to ldonoso/percona-server that referenced this pull request Mar 15, 2022
@yoshinorim @inikep
Set exclusive_manual_compaction = false on manual compactions (percon…
b8abfe5 
…a#682) (percona#682)

Summary:
Combining exclusive manual compaction and
non-exclusive manual compaction may hit rocksdb assertion errors.
This diff makes all MyRocks internal manual compactions non exclusive.
Closes facebook/mysql-5.6#682

Differential Revision: D5633619

Pulled By: yoshinorim
inikep pushed a commit to inikep/mysql-5.6 that referenced this pull request May 20, 2022
@yoshinorim @inikep
Set exclusive_manual_compaction = false on manual compactions (facebo…
b220221 
…ok#682) (facebook#682)

Summary:
Combining exclusive manual compaction and
non-exclusive manual compaction may hit rocksdb assertion errors.
This diff makes all MyRocks internal manual compactions non exclusive.
Closes facebook#682

Differential Revision: D5633619

Pulled By: yoshinorim
inikep pushed a commit to inikep/mysql-5.6 that referenced this pull request May 23, 2022
@yoshinorim @inikep
Set exclusive_manual_compaction = false on manual compactions (facebo…
780d19a 
…ok#682) (facebook#682)

Summary:
Combining exclusive manual compaction and
non-exclusive manual compaction may hit rocksdb assertion errors.
This diff makes all MyRocks internal manual compactions non exclusive.
Closes facebook#682

Differential Revision: D5633619

Pulled By: yoshinorim
laurynas-biveinis pushed a commit to laurynas-biveinis/mysql-5.6 that referenced this pull request Aug 11, 2022
@yoshinorim
Set exclusive_manual_compaction = false on manual compactions (facebo…
02c891b 
…ok#682) (facebook#682)

Summary:
Combining exclusive manual compaction and
non-exclusive manual compaction may hit rocksdb assertion errors.
This diff makes all MyRocks internal manual compactions non exclusive.
Closes facebook#682

Differential Revision: D5633619

Pulled By: yoshinorim
inikep pushed a commit to inikep/mysql-5.6 that referenced this pull request Mar 25, 2023
@yoshinorim @inikep
Set exclusive_manual_compaction = false on manual compactions (facebo…
c2011b9 
…ok#682) (facebook#682)

Summary:
Combining exclusive manual compaction and
non-exclusive manual compaction may hit rocksdb assertion errors.
This diff makes all MyRocks internal manual compactions non exclusive.
Closes facebook#682

Differential Revision: D5633619

Pulled By: yoshinorim
inikep pushed a commit to inikep/mysql-5.6 that referenced this pull request Mar 28, 2023
@yoshinorim @inikep
Set exclusive_manual_compaction = false on manual compactions (facebo…
5a0b21c 
…ok#682) (facebook#682)

Summary:
Combining exclusive manual compaction and
non-exclusive manual compaction may hit rocksdb assertion errors.
This diff makes all MyRocks internal manual compactions non exclusive.
Closes facebook#682

Differential Revision: D5633619

Pulled By: yoshinorim
inikep pushed a commit to inikep/mysql-5.6 that referenced this pull request Jun 1, 2023
@yoshinorim @inikep
Set exclusive_manual_compaction = false on manual compactions (facebo…
6e8289c 
…ok#682) (facebook#682)

Summary:
Combining exclusive manual compaction and
non-exclusive manual compaction may hit rocksdb assertion errors.
This diff makes all MyRocks internal manual compactions non exclusive.
Closes facebook#682

Differential Revision: D5633619

Pulled By: yoshinorim
inikep pushed a commit to inikep/mysql-5.6 that referenced this pull request Jun 14, 2023
@yoshinorim @inikep
Set exclusive_manual_compaction = false on manual compactions (facebo…
fbda692 
…ok#682) (facebook#682)

Summary:
Combining exclusive manual compaction and
non-exclusive manual compaction may hit rocksdb assertion errors.
This diff makes all MyRocks internal manual compactions non exclusive.
Closes facebook#682

Differential Revision: D5633619

Pulled By: yoshinorim
inikep pushed a commit to inikep/percona-server that referenced this pull request Apr 9, 2024
@yoshinorim @inikep
Set exclusive_manual_compaction = false on manual compactions (percon…
81d0fda 
…a#682) (percona#682)

Summary:
Combining exclusive manual compaction and
non-exclusive manual compaction may hit rocksdb assertion errors.
This diff makes all MyRocks internal manual compactions non exclusive.
Closes facebook/mysql-5.6#682

Differential Revision: D5633619

Pulled By: yoshinorim
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hermanlee hermanlee hermanlee approved these changes

Assignees

No one assigned

Labels

CLA Signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@yoshinorim @facebook-github-bot @hermanlee