Update search path prefix when getting source db#2380
Closed
connernilsen wants to merge 2 commits intofacebook:mainfrom
Closed
Update search path prefix when getting source db#2380connernilsen wants to merge 2 commits intofacebook:mainfrom
connernilsen wants to merge 2 commits intofacebook:mainfrom
Conversation
Reviewed By: kinto0 Differential Revision: D92773270
Summary: This should fix the sourcedb bug Jia mentioned last week, where sometimes search path prefix entries aren't used correctly. This happens when there's already a sourcedb entry loaded, so we skip appending the config root to the search path as expected. Reviewed By: kinto0 Differential Revision: D92848242
|
@connernilsen has exported this pull request. If you are a Meta employee, you can view the originating Diff in D92848242. |
kinto0
approved these changes
Feb 10, 2026
Contributor
kinto0
left a comment
kinto0
left a comment
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
|
This pull request has been merged in 3bfe376. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: This should fix the sourcedb bug Jia mentioned last week, where sometimes search path prefix entries aren't used correctly. This happens when there's already a sourcedb entry loaded, so we skip appending the config root to the search path as expected.
Reviewed By: kinto0
Differential Revision: D92848242