fix(suppress): handle removal of unused ignores#3200
Open
rexledesma wants to merge 1 commit intofacebook:mainfrom
Open
fix(suppress): handle removal of unused ignores#3200rexledesma wants to merge 1 commit intofacebook:mainfrom
rexledesma wants to merge 1 commit intofacebook:mainfrom
Conversation
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
Contributor
|
Thanks for the issue and fix! cc @maggiemoss I will import it but I want her to get a second look |
Contributor
|
@kinto0 has imported this pull request. If you are a Meta employee, you can view this in D102371578. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ensure that
pyrefly suppress --remove-unusedactually works.Fixes #3198.
Test Plan
cargo test