Hard code using the dir entry cache struct (#3994)#3994
Closed
kinto0 wants to merge 1 commit into
Closed
Conversation
Contributor
|
@kinto0 has exported this pull request. If you are a Meta employee, you can view the originating Diff in D109356961. |
grievejia
approved these changes
Jun 30, 2026
grievejia
left a comment
grievejia
left a comment
Contributor
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
This comment has been minimized.
This comment has been minimized.
Summary: Internal results using telemetry show that using directory caching speeds up did open operations and improves language server speed. This experiment has been running for a few weeks now, and things are looking good, so let's just enable this fully Reviewed By: grievejia Differential Revision: D109356961
meta-codesync
Bot
changed the title
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
Contributor
|
This pull request has been merged in babb7c9. |
This was referenced Jul 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Internal results using telemetry show that using directory caching speeds up did open operations and improves language server speed. This experiment has been running for a few weeks now, and things are looking good, so let's just enable this fully
Reviewed By: grievejia
Differential Revision: D109356961