fix pd.read_csv inferred type is Unknown but go to definition works. #1819#4185
Closed
asukaminato0721 wants to merge 1 commit into
Closed
fix pd.read_csv inferred type is Unknown but go to definition works. #1819#4185asukaminato0721 wants to merge 1 commit into
asukaminato0721 wants to merge 1 commit into
Conversation
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
Member
|
Closing in favor of #4286 which fixes the underlying issue in a more general way |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1819
Root cause: bundled stubs could resolve foo.pyi instead of
foo/__init__.pyi.For pandas, that selected an empty pandas.io.parsers.pyi, losing the read_csv export.
Bundled resolution now matches Python’s package-first precedence across all bundled stub sources.
Test Plan
add test