Add test for NotIterable error in starred tuple unpacking (#4189)#4189
Closed
anushamukka-dev wants to merge 1 commit into
Closed
Add test for NotIterable error in starred tuple unpacking (#4189)#4189anushamukka-dev wants to merge 1 commit into
anushamukka-dev wants to merge 1 commit into
Conversation
Contributor
|
@anushamukka-dev has exported this pull request. If you are a Meta employee, you can view the originating Diff in D112538198. |
This comment has been minimized.
This comment has been minimized.
) Summary: The error path in `expr.rs` that reports `Expected an iterable, got ...` when a non-iterable type is used with star (`*`) unpacking in a tuple display (e.g. `(*x,)`) carried a `// TODO: missing test` marker and had no dedicated test coverage. This adds `test_unpack_starred_not_iterable_in_tuple`, which unpacks an `int` into a tuple display and expects the `NotIterable` error, and removes the now-resolved TODO comment. Differential Revision: D112538198
meta-codesync
Bot
changed the title
anushamukka-dev
force-pushed
the
export-D112538198
branch
from
July 21, 2026 21:38
b572d3f to
812aba1
Compare
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
yangdanny97
approved these changes
Jul 22, 2026
yangdanny97
left a comment
yangdanny97
left a comment
Contributor
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
Contributor
|
This pull request has been merged in ad598b2. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
The error path in
expr.rsthat reportsExpected an iterable, got ...when a non-iterable type is used with star (
*) unpacking in a tupledisplay (e.g.
(*x,)) carried a// TODO: missing testmarker and had nodedicated test coverage.
This adds
test_unpack_starred_not_iterable_in_tuple, which unpacks anintinto a tuple display and expects the
NotIterableerror, and removes thenow-resolved TODO comment.
Differential Revision: D112538198