[pyrefly] Recognize inherited comparisons for total_ordering - #4386
Open
lyydsheep wants to merge 1 commit into
Open
[pyrefly] Recognize inherited comparisons for total_ordering#4386lyydsheep wants to merge 1 commit into
lyydsheep wants to merge 1 commit into
Conversation
Contributor
|
This pull request has been imported. If you are a Meta employee, you can view this in D114456358. (Because this pull request was imported automatically, there will not be any future comments.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4379
@total_orderingnow recognizes non-synthesized rich comparison methods inherited through the class MRO and uses them when synthesizing missing comparisons. Direct methods, builtinobjectbehavior, and existing diagnostics remain unchanged.Validation:
cargo test -p pyrefly test_total_orderingpython3 test.py --no-test --no-tensor-shapes --no-conformance --no-jsonschemaThe local
.scratchplanning files are intentionally not part of this PR.