fix panic: Key Anon already exists with value ClassDef w/ NamedTuple and assert #4447

[asukaminato0721]

Summary

Fixes #4447

Removed redundant anonymous binding for assert conditions, preventing collision with synthesized NamedTuple bindings.

Test Plan

add test

[meta-codesync]

This pull request has been imported. If you are a Meta employee, you can view this in D114829883. (Because this pull request was imported automatically, there will not be any future comments.)

[github-actions]

According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅

[yangdanny97]

The anon binding was there for catching type errors in the test expression. Can you verify that an assert test w/ a type error still gets flagged?

[asukaminato0721]

The anon binding was there for catching type errors in the test expression. Can you verify that an assert test w/ a type error still gets flagged?

yes, cargo test -p pyrefly --lib test::simple::test_assert -- --exact --nocapture works

because

pyrefly/pyrefly/lib/alt/solve.rs

Lines 2468 to 2469 in 39ec293

	BindingExpect::Bool(x) => {
	let ty = self.expr_infer(x, errors);

[yangdanny97]

Review automatically exported from Phabricator review in Meta.

[meta-codesync]

This pull request has been merged in f7e444a.