Allow subclass receivers on overloaded constructors - #4722
Conversation
Overloaded ordinary methods already skip self/cls superclass checks so receiver annotations can participate in overload selection. Apply the same rule to overloaded __new__/__init__ stubs while still validating non-overload constructors and implementations. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Hi @Divyansh151005! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
Summary
Overloaded ordinary methods and classmethods already skip
self/clssuperclass validation on overload stubs, so concrete subclass receivers can participate in overload selection. Overloaded__new__and__init__were still always validated (should_validate = is_constructor || !is_overload), which rejected valid patterns such as:This change treats constructor overload stubs like other overload stubs: skip per-overload receiver superclass checks, while still validating non-overload constructors and implementation signatures.
Fixes #4701
Test Plan